Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset replaces our old vendored and modified NTLM implementation with https://github.com/WinRb/rubyntlm
Verification
msfconsole
use auxiliary/scanner/smb/smb_login
use auxiliary/scanner/mssql/mssql_login
sa
)set DOMAIN
to the hostname (not fqdn) of the target system. For some reason.
andWORKSTATION
both fail, but this is existing behavior before these changes.use auxiliary/scanner/mssql/mssql_hashdump
(this is important because it's different code from the login scanner)sa
)set DOMAIN
to the hostname (not fqdn) of the target system. For some reason.
andWORKSTATION
both fail, but this is existing behavior before these changes.use auxiliary/scanner/http/http_login