Skip to content

Conversation

@flibustier
Copy link
Contributor

  • Fixing StoreDB function on msfcrawler

  • Add sub-module for catching links in html comments

  • Fixing errors in 'data/msfcrawler/forms.rb' sub-module :

[*] ERROR
[*] undefined method `empty?' for nil:NilClass: ["(eval):35:in `block in parse'", 

and

encoding error : output conversion failed due to conv error, bytes 0xA4 0x31 0x2E 0x30
I/O error : encoder error
  • Remove old banners, "rubygems" requirements, executable marks

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use auxiliary/crawler/msfcrawler
  • set StoreDB true
  • set the other options required
  • run
  • Verify It should work, you can verify with wmap_sites -l for example

@wvu wvu self-assigned this Mar 14, 2017
@wvu
Copy link
Contributor

wvu commented Mar 14, 2017

Ye olde msfcrawler. Why are these files still in the data directory? Does anyone still use this?

@wvu
Copy link
Contributor

wvu commented Mar 16, 2017

Can we just rm the whole thing? I know you put a lot of work into this, but I'm skeptical anyone still uses this enough for us to keep it.

@h00die
Copy link
Contributor

h00die commented Mar 16, 2017

Googling msfcrawler the results are all rapid7's, git, and a blog post over a year old... Don't think unleashed has this in it. I'm not sure many would notice it being gone...

@wvu
Copy link
Contributor

wvu commented Mar 17, 2017

I'm sure someone uses it. I also hate to rm someone's hard work. We'll decide what to do at a later date...

wvu added a commit to wvu/metasploit-framework that referenced this pull request Mar 17, 2017
Does anyone use this anymore??
@wvu wvu merged commit 665adec into rapid7:master Mar 17, 2017
@flibustier flibustier deleted the msfcrawler_improvement branch March 17, 2017 08:47
@wvu
Copy link
Contributor

wvu commented Mar 22, 2017

Release Notes

Fixes and improvements were made to msfcrawler.

@tdoan-r7 tdoan-r7 added the rn-fix release notes fix label Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug library rn-fix release notes fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants