Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reference to the original PR #8262

Merged
merged 2 commits into from Apr 18, 2017
Merged

Conversation

todb-r7
Copy link

@todb-r7 todb-r7 commented Apr 18, 2017

This adds a reference to the recent Huawei module from PR #8245.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • info exploit/linux/http/huawei_hg532n_cmdinject
  • Verify the reference to the MSF PR queue is shown.

This was the source of first public disclosure, so may as well include
it.
@todb-r7
Copy link
Author

todb-r7 commented Apr 18, 2017

I coulda sworn msftidy checked for references in exploits, btw, but apparently it just checks for proper format if a reference is given.

@wvu
Copy link
Contributor

wvu commented Apr 18, 2017

Oof, can't believe I missed this. cc @busterb

@wvu wvu self-assigned this Apr 18, 2017
@wvu
Copy link
Contributor

wvu commented Apr 18, 2017

Landing since I reviewed and tested the module.

@wvu wvu merged commit 1fcc1f7 into rapid7:master Apr 18, 2017
wvu added a commit that referenced this pull request Apr 18, 2017
@busterb
Copy link
Member

busterb commented Apr 18, 2017

It's typical that we add references when there are none? TIL.

@busterb
Copy link
Member

busterb commented Apr 18, 2017

Note, this module also is totally self-documented. I'd say that now that we have module documentation, that references are a little less important than they used to be.

@egypt
Copy link
Contributor

egypt commented Apr 18, 2017

@busterb by convention, all exploits should have at least one Reference. This looks legit to me.

@busterb
Copy link
Member

busterb commented Apr 19, 2017

I'm guessing part of the motivation here as well is so that vulndb links back to something. Since the 'info -d' command already resolves the module PR as a reference link automatically (and if you do it with this module, you now get 2 links to the PR), it would be nice to fix vulndb to follow suit.

@busterb busterb added the rn-no-release-notes no release notes label Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants