Skip to content

Update enum_ms_product_keys to only run on supported versions. #901

Closed
wants to merge 1 commit into from

4 participants

@brandonprry

This pull request updates the enum_ms_product_keys module to only run on XP, Vista, or 7. Above windows 7, MS removes the license key from the registry, so the module is not useful.

@jlee-r7 jlee-r7 commented on the diff Oct 13, 2012
modules/post/windows/gather/enum_ms_product_keys.rb
print_status("Finding Microsoft key on #{sysinfo['Computer']}")
app_list
end
+ #MS removes the key from the registry after windows 7
+ def os_supportable?(os)
+ return true if os =~ / XP / || os =~ / Vista / || os =~ / 7 /
@jlee-r7
jlee-r7 added a note Oct 13, 2012

2000?

@wchen-r7
wchen-r7 added a note Oct 13, 2012

2000?

@FireFart
FireFart added a note Oct 13, 2012

what about the server products? server 2000, 2003 and 2008?

@brandonprry
brandonprry added a note Oct 13, 2012

Server 2008 falls to the same issue as windows 8, the key is being removed after activation. Server/2000 and 2003 though I totally forgot about and don't have machines available off hand to test with. Let me see if I can fix this so I can test them as well.

@FireFart
FireFart added a note Oct 14, 2012

Are you sure that 2008 will not work? 2008 and Windows 7 share the same kernel. The Windows 8 like Server product would be Server 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@brandonprry brandonprry reopened this Oct 13, 2012
@brandonprry

Will reopen when I test all the server variants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.