Fixing undefined local variable in timestomp.rb and the passing of Time object instances to string function #9070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2017 06:28
… & get_file_mace already returns a 'Time' object instance
|
Thanks a lot @landhb - sorry about that! |
busterb
pushed a commit
to busterb/metasploit-framework
that referenced
this pull request
Oct 24, 2017
Release NotesThis fix address an issue that occurs when copying the MACE attributes from one file to another with the Meterpreter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an undefined local variable error for the "path" variable in timestomp.rb when utilizing the "-f" command line parameter. I believe the bug was introduced in #8897 when it was merged on Sept 1.
Additionally
client.priv.fs.get_file_macealready returns a Time object instance, so no need to pass the values tostr_to_timeVerification
List the steps needed to make sure this thing works
msfconsoletimestomp file1.txt -f "c:\\path\\to\\file2.txt"Original bug screenshots
Fixed screenshot