New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert passive handler #9178

Merged
merged 2 commits into from Nov 6, 2017

Conversation

Projects
None yet
3 participants
@busterb
Contributor

busterb commented Nov 6, 2017

Based on beginner user observations at Black Hat 2017 Metasploit training, I thought that optimizing multi/handler to the most common use-case would be a good thing. That is, making it run in the background without exiting as a passive stance module.

However, there have been a few problems in practice in changing this behavior:

  • There is no way to run a passive handler in the foreground
  • Bind payloads operate strangely
  • Running this default mode causes CPU usage to spike
  • And most importantly, it broke 10 years of blog/wiki/stack overflow canon, and a lot of sites do not explain how Passive exploits or the jobs command works. So it wasn't helpful for new users anyway 馃槥

With an upcoming Metasploit 5 development branch, I think we have the ability to do something better than making this module swim against the stream. So, I'm reverting it. Fixes #8982

@busterb busterb referenced this pull request Nov 6, 2017

Closed

Metasploit not opening meterpreter session #9174

0 of 1 task complete

@wvu-r7 wvu-r7 self-assigned this Nov 6, 2017

wvu-r7 added a commit to wvu-r7/metasploit-framework that referenced this pull request Nov 6, 2017

@wvu-r7 wvu-r7 merged commit cfeb0b7 into rapid7:master Nov 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@h00die

This comment has been minimized.

Show comment
Hide comment
@h00die

h00die Nov 7, 2017

Contributor

I cried, a lot today. poured 2 out, and cried some more.
background handler strong.

Contributor

h00die commented Nov 7, 2017

I cried, a lot today. poured 2 out, and cried some more.
background handler strong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment