New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow UTF-8 module names and authors #9398

Merged
merged 2 commits into from Jan 22, 2018

Conversation

Projects
None yet
5 participants
@busterb
Contributor

busterb commented Jan 12, 2018

It seems that 5 years ago (acdce4c), the ecosystem wasn't ready for UTF-8 module names or author fields. As of last year, we possibly converted the last ASCII holdout (Metasploit Pro database) to use and assume UTF-8 encoding.

This PR removes the MSFtidy check forbidding UTF-8. It seems to work fine in light testing:

https://imgur.com/a/ffVlA

Verification

  • Start msfconsole
  • Edit and reload a module with UTF-8 in its title and author fields
  • Verify you can reload and view the info hash for the module
  • Verify info -d renders correctly.
  • Verify https://www.rapid7.com/db doesn't explode (CC @rchapman-r7)

@wchen-r7 you may have some historical context on this

@bcoles

bcoles approved these changes Jan 12, 2018

Looks good to me

@bcoles bcoles referenced this pull request Jan 12, 2018

Merged

Add Apport /Abrt chroot Privilege Escalation exploit #9399

6 of 6 tasks complete

@wchen-r7 wchen-r7 self-assigned this Jan 12, 2018

@wvu-r7

wvu-r7 approved these changes Jan 13, 2018

@bcoles bcoles referenced this pull request Jan 13, 2018

Merged

umlaut #9404

@busterb busterb self-assigned this Jan 22, 2018

@busterb

This comment has been minimized.

Show comment
Hide comment
@busterb

busterb Jan 22, 2018

Contributor

We did some testing with vulndb, it works fine with UTF-8 as well.

Contributor

busterb commented Jan 22, 2018

We did some testing with vulndb, it works fine with UTF-8 as well.

@busterb busterb merged commit 6aebc1f into rapid7:master Jan 22, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

busterb added a commit that referenced this pull request Jan 22, 2018

@busterb

This comment has been minimized.

Show comment
Hide comment
@busterb

busterb Jan 22, 2018

Contributor

Release Notes

Metasploit's pre-commit development tool now allows UTF-8 characters in module and author names.

Contributor

busterb commented Jan 22, 2018

Release Notes

Metasploit's pre-commit development tool now allows UTF-8 characters in module and author names.

jmartin-r7 added a commit to jmartin-r7/metasploit-framework that referenced this pull request Jan 24, 2018

jmartin-r7 added a commit to jmartin-r7/metasploit-framework that referenced this pull request Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment