New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umlaut #9404

Merged
merged 1 commit into from Jan 22, 2018

Conversation

Projects
None yet
5 participants
@bcoles
Contributor

bcoles commented Jan 13, 2018

This module updates the Apache OptionsBleed module with the correct author's name.

Once #9398 is merged, UTF8 characters will be acceptable in module names and author names.

@bcoles bcoles requested a review from wvu-r7 Jan 13, 2018

@wvu-r7

wvu-r7 approved these changes Jan 13, 2018

In my professional opinion, this appears to be an umlaut.

@bcoles bcoles added the easy label Jan 13, 2018

@sempervictus

This comment has been minimized.

Show comment
Hide comment
@sempervictus

sempervictus Jan 13, 2018

Contributor

In recognition of the iPhone getting rebooted by text message a bit back, I have to ask, are we opening up any conceivable way to screw the user other than some decoding issue from a module they installed anyway?

Contributor

sempervictus commented Jan 13, 2018

In recognition of the iPhone getting rebooted by text message a bit back, I have to ask, are we opening up any conceivable way to screw the user other than some decoding issue from a module they installed anyway?

@bcoles

This comment has been minimized.

Show comment
Hide comment
@bcoles

bcoles Jan 13, 2018

Contributor

@sempervictus Probably best to raise this in #9398 .

This is the umlaut appreciation thread.

Contributor

bcoles commented Jan 13, 2018

@sempervictus Probably best to raise this in #9398 .

This is the umlaut appreciation thread.

@bcoles bcoles added the delayed label Jan 20, 2018

@busterb busterb merged commit d172259 into rapid7:master Jan 22, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

busterb added a commit that referenced this pull request Jan 22, 2018

@busterb busterb removed the delayed label Jan 22, 2018

@busterb busterb self-assigned this Jan 22, 2018

jmartin-r7 added a commit to jmartin-r7/metasploit-framework that referenced this pull request Jan 24, 2018

jmartin-r7 added a commit to jmartin-r7/metasploit-framework that referenced this pull request Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment