New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby smb simple client #9986

Merged
merged 21 commits into from May 7, 2018

Conversation

Projects
None yet
4 participants
@busterb
Copy link
Contributor

busterb commented May 7, 2018

This is a rebase of #9365 with a fresh history, @jrobles-r7 versions parameter and other fixes, along with some additional cleanups. There are more corner cases that also need ruby_smb additions, so still a WIP, but getting closer.

Under the covers, SimpleClient gains a versions parameter that is used to control which SMB versions it will support. By default, it enables only SMBv1, which leaves the traditional Rex path in place. If SMBv2 is added, ruby_smb is used instead.

Verification

With SMBv1/v2 enabled or disabled

  • verify working functionality of auxiliary/scanner/smb/smb_enumusers
  • verify working functionality of auxiliary/scanner/smb/smb_enumshares
  • verify working functionality of exploit/windows/smb/psexec
  • verify working functionality for auxiliary/admin/smb/upload_file
  • verify working functionality for auxiliary/admin/smb/download_file

@busterb busterb referenced this pull request May 7, 2018

Closed

Use ruby_smb client in SMB SimpleClient #9365

0 of 6 tasks complete

@busterb busterb force-pushed the busterb:ruby_smb_simple_client branch from 5255681 to 3e7e1e5 May 7, 2018

@busterb busterb self-assigned this May 7, 2018

@busterb busterb force-pushed the busterb:ruby_smb_simple_client branch from 8312547 to 0c391c4 May 7, 2018

@busterb busterb merged commit 0c391c4 into rapid7:master May 7, 2018

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully ran sanity checks.
Details
Metasploit Automation - Test Execution Successfully ran `autoPayloadTest.py`.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

busterb added a commit that referenced this pull request May 7, 2018

asoto-r7 added a commit to asoto-r7/metasploit-framework that referenced this pull request May 8, 2018

@asoto-r7 asoto-r7 referenced this pull request May 8, 2018

Merged

Revert deleted code from #9986. See issue #9993 #9994

0 of 8 tasks complete
@busterb

This comment has been minimized.

Copy link
Contributor

busterb commented May 8, 2018

Release Notes

Initial integration work with ruby_smb to add SMBv2/1 support to Metasploit's SMB mixin has been added. The module author can select whether SMBv2 support is needed (it is off by default) by setting the versions: parameter on connect. This is currently enabled for file upload/download by default.

msjenkins-r7 added a commit that referenced this pull request May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment