New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream socket.rb matchers #5

Merged
merged 1 commit into from Jun 25, 2017

Conversation

Projects
None yet
2 participants
@sempervictus

sempervictus commented Jun 25, 2017

Add regex for matching MAC addresses, as well as convenience
methods for checking if a string matches the regex, as well as a
generic :is_ip? method to verify if something is either IPv4 or v6.

RageLtMan
Upstream socket.rb matchers
Add regex for matching MAC addresses, as well as convenience
methods for checking if a string matches the regex, as well as a
generic :is_ip? method to verify if something is either IPv4 or v6.
@sempervictus

This comment has been minimized.

Show comment
Hide comment
@sempervictus

sempervictus Jun 25, 2017

This is required for MSF PR #6611 upstreaming native DNS functionality.

Thanks @mubix for finding this, its invisible to my own tests since the forked gem has had this since prior to Rex separation efforts... can't actually trace the original date.

sempervictus commented Jun 25, 2017

This is required for MSF PR #6611 upstreaming native DNS functionality.

Thanks @mubix for finding this, its invisible to my own tests since the forked gem has had this since prior to Rex separation efforts... can't actually trace the original date.

@busterb busterb merged commit bdbdd27 into rapid7:master Jun 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

busterb pushed a commit that referenced this pull request Jun 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment