Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email test not working as intended thank to missing comma #1599

Closed
code-review-doctor opened this issue Jan 4, 2022 · 1 comment
Closed

Comments

@code-review-doctor
Copy link

This test has missing comma on line 572

"example-indeed@strange-example.com",
"#!$%&'*+-/=?^_`{}|~@example.org",
'"()<>[]:,;@\\"!#$%&\'-/=?^_`{}| ~.a"@example.org' '" "@example.org',
"example@localhost",
"example@s.solutions",
# Cases from Django tests

it's hard to spot so I will break it down a bit. Line 572:

'"()<>[]:,;@\"!#$%&'-/=?^_`{}| ~.a"@example.org' '" "@example.org',

should have a comma after ple.org' ie

'"()<>[]:,;@\"!#$%&'-/=?^_`{}| ~.a"@example.org', '" "@example.org',

The absence of this comma means the two strings are implicitly concatenated together.

This means the email test is not covering those two email addresses and instead uses '"()<>[]:,;@\"!#$%&'-/=?^_`{}| ~.a"@example.org" "@example.org',

I can make a PR to fix this for you?

@rowanseymour
Copy link
Contributor

Good spot - I just fixed this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants