Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Python bindings for dlpack #1159

Merged
merged 26 commits into from Mar 13, 2019

Conversation

@kkraus14
Copy link
Collaborator

@kkraus14 kkraus14 commented Mar 11, 2019

Fixes #1046

Note it assumes (and warns) that the input/output are column major, which may not be expected. #1175 recommends adding support for both row and column major, with an explicit option.

NOTE: Also disabled the test_gpu_memory_usage_with_boolmask test as it's been wreaking havoc on CI.

Copy link
Member

@harrism harrism left a comment

A few suggestions.

python/cudf/bindings/dlpack.pyx Show resolved Hide resolved
python/cudf/bindings/dlpack.pyx Show resolved Hide resolved
python/cudf/bindings/dlpack.pyx Show resolved Hide resolved
@harrism harrism added this to PR-WIP in v0.6 Release via automation Mar 12, 2019
@harrism harrism requested review from thomcom and jrhemstad Mar 13, 2019
@harrism harrism moved this from PR-WIP to PR-Needs review in v0.6 Release Mar 13, 2019
@kkraus14 kkraus14 changed the title [WIP] Python bindings for dlpack [REVIEW] Python bindings for dlpack Mar 13, 2019
@kkraus14 kkraus14 dismissed harrism’s stale review Mar 13, 2019

Comments addressed

python/cudf/bindings/dlpack.pxd Outdated Show resolved Hide resolved
python/cudf/bindings/dlpack.pyx Outdated Show resolved Hide resolved
python/cudf/bindings/dlpack.pyx Outdated Show resolved Hide resolved
python/cudf/bindings/dlpack.pyx Show resolved Hide resolved
python/cudf/dataframe/column.py Show resolved Hide resolved
python/cudf/dataframe/series.py Show resolved Hide resolved
python/cudf/io/dlpack.py Outdated Show resolved Hide resolved
… catch exception and raise exception properly
v0.6 Release automation moved this from PR-Needs review to PR-Reviewer approved Mar 13, 2019
@thomcom thomcom self-requested a review Mar 13, 2019
@kkraus14 kkraus14 merged commit 80fbb29 into rapidsai:branch-0.6 Mar 13, 2019
8 of 12 checks passed
v0.6 Release automation moved this from PR-Reviewer approved to Done Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v0.6 Release
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants