Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Python bindings for dlpack #1159

Merged
merged 26 commits into from Mar 13, 2019

Conversation

Projects
4 participants
@kkraus14
Copy link
Member

commented Mar 11, 2019

Fixes #1046

Note it assumes (and warns) that the input/output are column major, which may not be expected. #1175 recommends adding support for both row and column major, with an explicit option.

NOTE: Also disabled the test_gpu_memory_usage_with_boolmask test as it's been wreaking havoc on CI.

@harrism
Copy link
Member

left a comment

A few suggestions.

Show resolved Hide resolved python/cudf/bindings/dlpack.pyx
Show resolved Hide resolved python/cudf/bindings/dlpack.pyx
Show resolved Hide resolved python/cudf/bindings/dlpack.pyx

kkraus14 and others added some commits Mar 11, 2019

@harrism harrism added this to PR-WIP in v0.6 Release via automation Mar 12, 2019

@harrism harrism requested review from thomcom and jrhemstad Mar 13, 2019

@harrism harrism moved this from PR-WIP to PR-Needs review in v0.6 Release Mar 13, 2019

@kkraus14 kkraus14 changed the title [WIP] Python bindings for dlpack [REVIEW] Python bindings for dlpack Mar 13, 2019

Comments addressed

Show resolved Hide resolved python/cudf/bindings/dlpack.pxd Outdated
Show resolved Hide resolved python/cudf/bindings/dlpack.pyx Outdated
Show resolved Hide resolved python/cudf/bindings/dlpack.pyx Outdated
Show resolved Hide resolved python/cudf/bindings/dlpack.pyx
Show resolved Hide resolved python/cudf/dataframe/column.py
Show resolved Hide resolved python/cudf/dataframe/series.py
Show resolved Hide resolved python/cudf/io/dlpack.py Outdated
Removed unused header attributes / structs, rename pycapsule deleter,…
… catch exception and raise exception properly

v0.6 Release automation moved this from PR-Needs review to PR-Reviewer approved Mar 13, 2019

@thomcom thomcom self-requested a review Mar 13, 2019

@kkraus14 kkraus14 merged commit 80fbb29 into rapidsai:branch-0.6 Mar 13, 2019

8 of 12 checks passed

gpuCI/cudf-cpu-prb/ubuntu16.04-cuda9.2-py3.6 Test build triggered
Details
gpuCI/cudf-cpu-prb/ubuntu16.04-cuda9.2-py3.7 Test build triggered
Details
gpuCI/cudf-cpu-prb/ubuntu18.04-cuda10.0-py3.6 Test build triggered
Details
gpuCI/cudf-cpu-prb/ubuntu18.04-cuda10.0-py3.7 Test build triggered
Details
gpuCI/cudf-cpu-prb Build finished.
Details
gpuCI/cudf-cpu-prb/changelog Build #2399 succeeded in 1.8 sec
Details
gpuCI/cudf-cpu-prb/cuda10.0-py3.6 Build #13860 succeeded in 32 min
Details
gpuCI/cudf-cpu-prb/cuda10.0-py3.7 Build #13862 succeeded in 30 min
Details
gpuCI/cudf-cpu-prb/cuda9.2-py3.6 Build #13859 succeeded in 29 min
Details
gpuCI/cudf-cpu-prb/cuda9.2-py3.7 Build #13861 succeeded in 28 min
Details
gpuCI/cudf-cpu-prb/style Build #2508 succeeded in 4.1 sec
Details
gpuCI/cudf-gpu-prb Build finished. 7964 tests run, 773 skipped, 0 failed.
Details

v0.6 Release automation moved this from PR-Reviewer approved to Done Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.