Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure astype("interval") only matches the "interval" string #15261

Closed

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Mar 8, 2024

Description

#15125 got merged first before #14961 and I forgot to rebase the former which had an impact on that PR

This should unblock current cudf Python test failures

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Mar 8, 2024
@mroeschke mroeschke requested a review from a team as a code owner March 8, 2024 22:42
@mroeschke mroeschke requested review from wence- and shwina March 8, 2024 22:42
@mroeschke mroeschke changed the title Ensure only matches the string Ensure astype("interval") only matches the "interval" string Mar 8, 2024
@bdice bdice mentioned this pull request Mar 10, 2024
3 tasks
@bdice
Copy link
Contributor

bdice commented Mar 11, 2024

Closing as completed by #15265.

@bdice bdice closed this Mar 11, 2024
rapids-bot bot pushed a commit that referenced this pull request Mar 11, 2024
This reverts part of commit c794ce4. This PR can be merged after the docs.rapids.ai issues are resolved. cc: @raydouglass @AyodeAwe

PR #15265 unblocked CI for cudf by disabling errors in the docs. However, it also included the diff from #15261 so that CI would pass. This reverts the docs build changes but leaves in the changes from #15261.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #15269
@mroeschke mroeschke deleted the bug/astype/interval branch March 11, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants