New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fixing cmake to pull from conda env #342
Conversation
Fixes unexpected build errors when HTTP request times out
This will deal with HTTP errors that break the process when trying to setup the environment for the build
Ensure that no HTTP issues block uploads from occurring
@@ -1,5 +1,6 @@ | |||
name: pycudf_testing_py35 | |||
channels: | |||
- nvidia | |||
- numba | |||
- conda-forge | |||
- rapidsai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest moving rapidsai above conda-forge in case someone starts repackaging rapids libraries in conda-forge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why didn't this comment get incorporated in the final PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's moreso nitpicking and can be addressed in the future.
LGTM other than reordering conda channels in commands to prevent possible outdated versions of dependencies. |
Co-Authored-By: ogreen <ogreen@gatech.edu>
Co-Authored-By: ogreen <ogreen@gatech.edu>
Co-Authored-By: ogreen <ogreen@gatech.edu>
Co-Authored-By: ogreen <ogreen@gatech.edu>
Co-Authored-By: ogreen <ogreen@gatech.edu>
Co-Authored-By: ogreen <ogreen@gatech.edu>
With the introduction of strings into libgdf, we need to be able to get the header files and lib file from the conda-environment.