[WIP] Fixing cmake to pull from conda env #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes unexpected build errors when HTTP request times out
This will deal with HTTP errors that break the process when trying to setup the environment for the build
Ensure that no HTTP issues block uploads from occurring
kkraus14
changed the title
kkraus14
reviewed
Nov 7, 2018
kkraus14
reviewed
Nov 7, 2018
kkraus14
reviewed
Nov 7, 2018
kkraus14
reviewed
Nov 7, 2018
| @@ -1,5 +1,6 @@ | |||
| name: pycudf_testing_py35 | |||
| channels: | |||
| - nvidia | |||
| - numba | |||
| - conda-forge | |||
| - rapidsai | |||
There was a problem hiding this comment.
Suggest moving rapidsai above conda-forge in case someone starts repackaging rapids libraries in conda-forge.
There was a problem hiding this comment.
Why didn't this comment get incorporated in the final PR?
There was a problem hiding this comment.
It's moreso nitpicking and can be addressed in the future.
BradReesWork
approved these changes
Nov 7, 2018
kkraus14
reviewed
Nov 7, 2018
kkraus14
reviewed
Nov 7, 2018
kkraus14
reviewed
Nov 7, 2018
|
LGTM other than reordering conda channels in commands to prevent possible outdated versions of dependencies. |
Co-Authored-By: ogreen <ogreen@gatech.edu>
Co-Authored-By: ogreen <ogreen@gatech.edu>
Co-Authored-By: ogreen <ogreen@gatech.edu>
Co-Authored-By: ogreen <ogreen@gatech.edu>
Co-Authored-By: ogreen <ogreen@gatech.edu>
Co-Authored-By: ogreen <ogreen@gatech.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of strings into libgdf, we need to be able to get the header files and lib file from the conda-environment.