Change cudf::scalar copy and move constructors to protected #8857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8857 +/- ##
================================================
- Coverage 10.67% 10.59% -0.09%
================================================
Files 110 116 +6
Lines 18271 19034 +763
================================================
+ Hits 1951 2017 +66
- Misses 16320 17017 +697
Continue to review full report at Codecov.
|
davidwendt
added
3 - Ready for Review
davidwendt
requested review from
vyasr,
ttnghia and
karthikeyann
and removed request for
ttnghia
karthikeyann
approved these changes
Jul 28, 2021
vyasr
approved these changes
Jul 28, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An instance of the
cudf::scalarbase class can currently through it's public copy constructor using the following example:This line builds the numeric scalar instance, passes it to the base scalar's copy-ctor, and then destroys it.
(Simpler example here to show that this is happening: https://godbolt.org/z/hGEGvsqjq )
This means that the
binstance is actually a plaincudf::scalarwith no derived type.Downcasting with dynamic_cast can runtime-check the object but we could have this line fail at compile time by making the
cudf::scalarcopy-ctor protected.We could make the ctor explicit but I think making it protected would more clearly communicate the intention of the class.
This PR makes the
cudf::scalarcopy and move constructors protected to prevent instantiating acudf::scalarat compile time.