Fix branch_stack calculation in row_bit_count()
#9076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For input with a number of rows exceeding `max_block_size`, `row_bit_count()` currently reaches past the bounds of its shared-memory allocation, causing illegal memory access errors like in (cudf/issues/8938)[rapidsai#8938]. This commit corrects the calculation of the branch stack's base address, and adds a test for this case.
|
Good fix. Thanks. |
mythrocks
added
3 - Ready for Review
nvdbaranec
approved these changes
Aug 19, 2021
mythrocks
removed
the
improvement
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9076 +/- ##
===============================================
Coverage ? 10.73%
===============================================
Files ? 114
Lines ? 19058
Branches ? 0
===============================================
Hits ? 2046
Misses ? 17012
Partials ? 0 Continue to review full report at Codecov.
|
nvdbaranec
approved these changes
Aug 20, 2021
ttnghia
approved these changes
Aug 21, 2021
karthikeyann
approved these changes
Aug 23, 2021
|
@gpucibot merge |
|
Thanks for the reviews, chaps. I've merged this change now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8938.
For input with a number of rows exceeding
max_block_size,row_bit_count()currentlyreaches past the bounds of its shared-memory allocation, causing illegal memory access
errors like in cudf/issues/8938.
This commit corrects the calculation of the branch stack's base address, and adds a
test for this case.