Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make_empty_scalar_like on list_type #9759

Merged
merged 2 commits into from Dec 2, 2021
Merged

Fix make_empty_scalar_like on list_type #9759

merged 2 commits into from Dec 2, 2021

Conversation

sperlingxx
Copy link
Contributor

@sperlingxx sperlingxx commented Nov 23, 2021 •
edited

Fixes #9758

In make_empty_scalar_like, we create list scalar with the list column itself, which is wrong. The correct way is with the child of list column.

@sperlingxx
fix make_empty_scalar_like
5c5b1d7 
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
@sperlingxx sperlingxx requested a review from a team as a code owner November 23, 2021 10:40
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 23, 2021
@sperlingxx sperlingxx added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change bug Something isn't working labels Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021 •
edited

Codecov Report

Merging #9759 (2a360ee) into branch-22.02 (967a333) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9759      +/-   ##
================================================
- Coverage         10.49%   10.12%   -0.37%     
================================================
  Files               119      119              
  Lines             20305    21248     +943     
================================================
+ Hits               2130     2151      +21     
- Misses            18175    19097     +922
Impacted Files Coverage Δ
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1811b5...2a360ee. Read the comment docs.

@sperlingxx
Copy link
Contributor Author

rerun tests

@caryr35 caryr35 added this to PR-WIP in v22.02 Release via automation Nov 24, 2021
@caryr35 caryr35 moved this from PR-WIP to PR-Reviewer approved in v22.02 Release Nov 24, 2021
@sperlingxx
Copy link
Contributor Author

rerun tests

@sperlingxx
Copy link
Contributor Author

@gpucibot merge

@sperlingxx
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c10966c into rapidsai:branch-22.02 Dec 2, 2021
v22.02 Release automation moved this from PR-Reviewer approved to Done Dec 2, 2021
@sperlingxx sperlingxx deleted the fix_make_empty_scalar branch December 2, 2021 10:48
@sperlingxx sperlingxx mentioned this pull request Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devavret devavret devavret approved these changes

@ttnghia ttnghia ttnghia approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
No open projects
v22.02 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] First reduction produces incorrect result type for inputs of list_type
3 participants
@sperlingxx @devavret @ttnghia