Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mg symmetrize tests #2278

Conversation

jnke2016
Copy link
Contributor

This PR refactors and fixes mg symmetrize tests
closes #2277

@jnke2016 jnke2016 requested a review from a team as a code owner May 17, 2022 08:27
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #2278 (ab0bb5d) into branch-22.06 (046cbd2) will not change coverage.
The diff coverage is n/a.

❗ Current head ab0bb5d differs from pull request most recent head e1e4e99. Consider uploading reports for the commit e1e4e99 to get more accurate results

@@              Coverage Diff              @@
##           branch-22.06    #2278   +/-   ##
=============================================
  Coverage         63.97%   63.97%           
=============================================
  Files               100      100           
  Lines              4436     4436           
=============================================
  Hits               2838     2838           
  Misses             1598     1598           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 046cbd2...e1e4e99. Read the comment docs.

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python labels May 17, 2022
@rlratzel rlratzel added this to the 22.06 milestone May 17, 2022
@BradReesWork BradReesWork added this to PRs in 22.06 Release May 19, 2022
Copy link
Contributor

@betochimas betochimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the updated testing refactoring, the main logic of the tests is intact with improved naming and relevant helpers. The debugging code if symmetrized edges aren't present also helps.

Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No recommendations here. looks great.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d25f990 into rapidsai:branch-22.06 May 27, 2022
22.06 Release automation moved this from PRs to Done May 27, 2022
@jnke2016 jnke2016 deleted the branch-22.06_fix_mg_symmetrize_tests branch September 24, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
22.06 Release
  
Done
Development

Successfully merging this pull request may close these issues.

[BUG] Broken MG tests caused by a change in the symmetrize function definition
7 participants