Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fea get params small changes #322

Merged
merged 15 commits into from Mar 13, 2019

Conversation

@Salonijain27
Copy link
Contributor

commented Mar 13, 2019

a small change was made to the files to make them more compatible with gridsearch

Salonijain27 added some commits Mar 12, 2019

@dantegd
Copy link
Member

left a comment

Two small changes, otherwise looks good

Show resolved Hide resolved CHANGELOG.md
Show resolved Hide resolved python/cuml/decomposition/pca.pyx Outdated

@quasiben quasiben referenced this pull request Mar 13, 2019

Closed

[REVIEW] fix/clf-solver #318

@dantegd dantegd added this to PR-WIP in v0.6 Release via automation Mar 13, 2019

Salonijain27 added some commits Mar 13, 2019

v0.6 Release automation moved this from PR-WIP to PR-Reviewer approved Mar 13, 2019

@GPUtester

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

Can one of the admins verify this patch?

@dantegd dantegd merged commit a31a43d into rapidsai:branch-0.6 Mar 13, 2019

7 of 11 checks passed

gpuCI/cuml-cpu-prb/ubuntu16.04-cuda9.2-py3.6 Test build triggered
Details
gpuCI/cuml-cpu-prb/ubuntu16.04-cuda9.2-py3.7 Test build triggered
Details
gpuCI/cuml-cpu-prb/ubuntu18.04-cuda10.0-py3.6 Test build triggered
Details
gpuCI/cuml-cpu-prb/ubuntu18.04-cuda10.0-py3.7 Test build triggered
Details
gpuCI/cudf-cpu-prb Build finished.
Details
gpuCI/cuml-cpu-prb/changelog Build #560 succeeded in 1.2 sec
Details
gpuCI/cuml-cpu-prb/cuda10.0-py3.6 Build #3552 succeeded in 27 min
Details
gpuCI/cuml-cpu-prb/cuda10.0-py3.7 Build #3555 succeeded in 26 min
Details
gpuCI/cuml-cpu-prb/cuda9.2-py3.6 Build #3554 succeeded in 26 min
Details
gpuCI/cuml-cpu-prb/cuda9.2-py3.7 Build #3553 succeeded in 26 min
Details
gpuCI/cuml-cpu-prb/style Build #559 succeeded in 2.6 sec
Details

v0.6 Release automation moved this from PR-Reviewer approved to Done Mar 13, 2019

@Salonijain27 Salonijain27 deleted the Salonijain27:fea-get-params branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.