Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map fit_transform to sklearn implementation #330

Merged
merged 2 commits into from Mar 14, 2019

Conversation

Projects
None yet
2 participants
@quasiben
Copy link
Contributor

commented Mar 14, 2019

This PR adds an ignored argument to fit_transform this is necessary to run PCA through sklearn's pipeline and maps to sklearn's implementation

cc @dantegd @Salonijain27

@quasiben quasiben changed the base branch from branch-0.7 to branch-0.6 Mar 14, 2019

@dantegd dantegd merged commit 5d18476 into rapidsai:branch-0.6 Mar 14, 2019

7 of 11 checks passed

gpuCI/cuml-cpu-prb/ubuntu16.04-cuda9.2-py3.6 Test build triggered
Details
gpuCI/cuml-cpu-prb/ubuntu16.04-cuda9.2-py3.7 Test build triggered
Details
gpuCI/cuml-cpu-prb/ubuntu18.04-cuda10.0-py3.6 Test build triggered
Details
gpuCI/cuml-cpu-prb/ubuntu18.04-cuda10.0-py3.7 Test build triggered
Details
gpuCI/cudf-cpu-prb Build finished.
Details
gpuCI/cuml-cpu-prb/changelog Build #568 succeeded in 1.2 sec
Details
gpuCI/cuml-cpu-prb/cuda10.0-py3.6 Build #3603 succeeded in 26 min
Details
gpuCI/cuml-cpu-prb/cuda10.0-py3.7 Build #3602 succeeded in 25 min
Details
gpuCI/cuml-cpu-prb/cuda9.2-py3.6 Build #3600 succeeded in 24 min
Details
gpuCI/cuml-cpu-prb/cuda9.2-py3.7 Build #3601 succeeded in 22 min
Details
gpuCI/cuml-cpu-prb/style Build #567 succeeded in 2.7 sec
Details

@quasiben quasiben changed the title add ignored argument to fit_transform to map to sklearn implementation map fit_transform to sklearn implementation Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.