Migrate from raft::device_resources -> raft::resources #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfred
added
improvement
this used to happen in the device_resources constructor - do it lazily now
Had automatically added headers in cuh/hpp/cu/cpp files - but had missed the .h ones
benfred
added a commit
to benfred/cuml
that referenced
this pull request
May 15, 2023
benfred
added a commit
to benfred/cugraph
that referenced
this pull request
May 15, 2023
cjnolet
approved these changes
May 16, 2023
There was a problem hiding this comment.
LGTM. Just a small suggestion that we can do as a follow-on. @divyegala is opening a PR to cuopt and I'm about to open one to cugraph-ops.
cjnolet
approved these changes
May 16, 2023
There was a problem hiding this comment.
LGTM. Just a small suggestion that we can do as a follow-on. @divyegala is opening a PR to cuopt and I'm about to open one to cugraph-ops.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.