Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raft-dask naming in wheel builds #1805

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

divyegala
Copy link
Member

Before https://github.com/rapidsai/raft/pull/1804/files, we were using raft-dask and raft_dask interchangeably because they were hardcoded. Since the package name is now capture as a variable, it's a bug to use raft_dask as the pyproject name does not get updated correctly and we end up publishing raft-dask wheels without cu{version} suffixes

@divyegala divyegala added bug Something isn't working non-breaking Non-breaking change labels Sep 6, 2023
@divyegala divyegala requested a review from a team as a code owner September 6, 2023 19:10
@divyegala divyegala self-assigned this Sep 6, 2023
@github-actions github-actions bot added the ci label Sep 6, 2023
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change mostly aligns with the fix we discussed, but I think you may have changed one too many places and you're going to run into some minor issues because of the way that some names get normalized. In particular, I think that the wheel names (like the actual filename) will still use raft_dask instead of raft-dask because that's the pip convention (convert hyphens to underscores). I could be wrong, but CI should reveal this for me. If you can test locally that might help you get through it faster so that you don't have to wait for pylibraft.

@divyegala
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit f691fc9 into rapidsai:branch-23.10 Sep 6, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants