Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C++ doxygen documentation #426

Merged
merged 3 commits into from
Dec 17, 2021
Merged

Fix C++ doxygen documentation #426

merged 3 commits into from
Dec 17, 2021

Conversation

achirkin
Copy link
Contributor

Make the doxygen docs buildable again. The changes:

  1. A minimal set of changes required for docs_raft target to complete successfully
  2. A build.sh section for building the docs target (as in cuml)
  3. CI target to make sure new documentation errors do not slip in.

@achirkin achirkin added bug Something isn't working non-breaking Non-breaking change 2 - In Progress Currenty a work in progress and removed cpp gpuCI labels Dec 17, 2021
@achirkin
Copy link
Contributor Author

rerun tests

@achirkin achirkin marked this pull request as ready for review December 17, 2021 12:50
@achirkin achirkin requested review from a team as code owners December 17, 2021 12:50
@achirkin achirkin added 3 - Ready for Review and removed 2 - In Progress Currenty a work in progress labels Dec 17, 2021
cjnolet
cjnolet approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great. Thanks for fixing this!

ajschmidt8
ajschmidt8 approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@cjnolet
Copy link
Member

cjnolet commented Dec 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f48612d into rapidsai:branch-22.02 Dec 17, 2021
@achirkin achirkin deleted the fix-doxygen branch March 31, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review bug Something isn't working cpp gpuCI non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achirkin @cjnolet @ajschmidt8