-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ivf_flat::index: hide implementation details #747
ivf_flat::index: hide implementation details #747
Conversation
…eparate out cuivfl handle init in separate func
Co-authored-by: Tamas Bela Feher <tfeher@nvidia.com>
Co-authored-by: Tamas Bela Feher <tfeher@nvidia.com>
…equirements CPU/GPU
…ded in .cpp files as before (in cuml)
…ded in .cpp files as before (in cuml)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @achirkin for these updates, I have a few small comments, otherwise in general it looks good to me.
} | ||
|
||
/** Inverted list indices: ids of items in the source data [size] */ | ||
[[nodiscard]] inline auto indices() const noexcept |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice and clean and it designates the ivf_flat::index
as the owning object without having to deal w/ the complexities and maintenance of transferring that ownership. I like this a lot.
This PR is ready for review, but should only be merged after #764 due to a bug in mdarrays (which causes cuml tests to segfault). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Artem for addressing the issues! The PR looks good to me.
rerun tests |
@achirkin I notice this PR is breaking but from the looks of the changes, it's only breaking for the new IVF-flat index API, right? If that's the case, are there any active consumers of this API that you know of which would break if we merged this? |
Yes, I marked it breaking because of the changes in the bew ivf-flat api, and I am not aware of anybody using it yet. |
@gpucibot merge |
Hide the mutable
mdarray
members ofivf_flat::index
behind immutablemdspan
views.