Permalink
Browse files

Todo comment that handling of malformed messages is poor.

  • Loading branch information...
1 parent a3f73d5 commit b642e94302435a1aa02903448e6e2fd8a2e2e144 @samstokes samstokes committed Oct 5, 2011
Showing with 5 additions and 0 deletions.
  1. +5 −0 src/main/java/com/rapportive/storm/spout/AMQPSpout.java
@@ -187,6 +187,11 @@ public void nextTuple() {
final long deliveryTag = delivery.getEnvelope().getDeliveryTag();
final byte[] message = delivery.getBody();
collector.emit(serialisationScheme.deserialize(message), deliveryTag);
+ /*
+ * TODO what to do about malformed messages? Skip?
+ * Avoid infinite retry!
+ * Maybe we should output them on a separate stream.
+ */
} catch (InterruptedException e) {
// interrupted while waiting for message, big deal
}

0 comments on commit b642e94

Please sign in to comment.