Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add class Range (WIP) #17

Merged
merged 4 commits into from Sep 3, 2019

Conversation

@VasavanThiru
Copy link
Contributor

commented Aug 6, 2019

range_ros

src/viz/Range.js Outdated Show resolved Hide resolved
src/viz/Range.js Outdated Show resolved Hide resolved

updateOptions(options) {
super.updateOptions(options);
const { color, alpha } = this.options;

This comment has been minimized.

Copy link
@wolfv

wolfv Aug 6, 2019

Collaborator

what options exist in RViz?

This comment has been minimized.

Copy link
@chaitanya-deep

chaitanya-deep Aug 24, 2019

Member

http://wiki.ros.org/rviz/DisplayTypes/Range

I guess the buffer length can be ignored for now

@lgtm-com

This comment has been minimized.

Copy link

commented Aug 24, 2019

This pull request introduces 4 alerts when merging 6c8f351 into a23a87a - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class
  • 1 for Superfluous trailing arguments

@chaitanya-deep chaitanya-deep requested a review from tocttou Aug 24, 2019

@tocttou tocttou merged commit 630f86c into rapyuta-robotics:devel Sep 3, 2019

3 checks passed

LGTM analysis: JavaScript No new or fixed alerts
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.