Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cbor compression for LaserScan, OccupancyGrid, and PointCloud #25

Merged
merged 2 commits into from Aug 13, 2019

Conversation

@tocttou
Copy link
Collaborator

commented Aug 8, 2019

For image and pointcloud types: Could not test because the viz didn't load.

Changed the compression to cbor for:

  1. PointCloud
  2. OccupancyGrid
  3. LaserScan

Others use the default JSON format as it seems to be the fastest for structured data.

Reference:

  1. RobotWebTools/rosbridge_suite#367
  2. Reason to not use cbor for Marker{Array}: RobotWebTools/ros3djs#239 (comment)

For the queue_size and throttle_rate, these should be controlled by parameters passed by the user in the sidebar. Rviz does not throttle any messages by default and it can lead to unexpected results if the user is not aware of the defaults. I am creating a task to add these options.

@tocttou tocttou merged commit e99e43c into devel Aug 13, 2019

3 checks passed

LGTM analysis: JavaScript No new or fixed alerts
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details

@chaitanya-deep chaitanya-deep deleted the feature/compression branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.