Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
added 8bit image encodings, image scaling on resize is now 1:1 with rviz #32
Goal is to have 1:1 correspondence with Rviz + other formats over that.
Rviz image types: http://wiki.ros.org/rviz/DisplayTypes/Image
RGB8 - implemented
for these 4 formats, rviz treats them as mono8 encoding, which appears to be incorrect to me (maybe it should be mono16 as it is 16UC1 type). for now we are keeping these as the same as in rviz, but later should investigate more and perhaps implement demosiac step to colorize the image. (https://github.com/codeplaysoftware/visioncpp/wiki/Example:-Bayer-Filter-Demosaic) (http://www.imagemagick.org/discourse-server/viewtopic.php?t=29459).
8UC4 - implemented
the following formats have not been implemented yet, but these are not supported in rviz either, implementation is easy but need to figure out a way to generate the 16/32bit images that has these encodings (will be doing this along with the tutorial for publishing images in the coming week). moreover, the data from these images must be normalized first (https://github.com/ros-visualization/rviz/blob/melodic-devel/src/rviz/image/ros_image_texture.cpp#L236)
Other encodings supported by ROS but not by rviz: http://docs.ros.org/jade/api/sensor_msgs/html/image__encodings_8h_source.html