Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc improvements to pointcloud viz: #33

Merged
merged 4 commits into from Aug 22, 2019

Conversation

@tocttou
Copy link
Collaborator

commented Aug 19, 2019

  1. added proper offset handling
  2. fields are now read according to their field.datatype
  3. added intensity setting
  4. optimized rendering and required memory
misc improvements to pointcloud viz:
1. added proper offset handling
2. fields are now read according to their field.datatype
3. added intensity setting
4. optimized rendering and required memory
@@ -5,7 +5,7 @@ export const OBJECT_TYPE_ARROW = 'Arrow';
export const OBJECT_TYPE_AXES = 'Axes';
export const OBJECT_TYPE_FLAT_ARROW = 'FlatArrow';

export const MAX_POINTCLOUD_POINTS = 100000;
export const MAX_POINTCLOUD_POINTS = 500000;

This comment has been minimized.

Copy link
@tocttou

tocttou Aug 19, 2019

Author Collaborator

Many pointclouds do not fit inside 100,000 points. 500,000 seems to be a better default to avoid confusion to the users (comes at the cost of extra memory). Ideally the buffer should resize if the number of data points change.

tocttou added 2 commits Aug 19, 2019
removed partial buffer update (was added for perf) that causes the po…
…ints from previous cycle to not render
src/utils/constants.js Outdated Show resolved Hide resolved
src/viz/PointCloud.js Outdated Show resolved Hide resolved
src/viz/PointCloud.js Outdated Show resolved Hide resolved

@tocttou tocttou merged commit 405b310 into devel Aug 22, 2019

3 checks passed

LGTM analysis: JavaScript No new or fixed alerts
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details

@tocttou tocttou deleted the bugfix/pointcloud-impl branch Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.