Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation of Wrench #37

Merged
merged 4 commits into from Sep 13, 2019

Conversation

@ThibaultLacharme
Copy link
Contributor

commented Aug 22, 2019

Wrench implementation based on Rviz implementation of the object

@ThibaultLacharme ThibaultLacharme force-pushed the ThibaultLacharme:wrench_stamped branch 2 times, most recently from 2c3606b to cc7d13a Aug 23, 2019

@ThibaultLacharme ThibaultLacharme marked this pull request as ready for review Aug 28, 2019

@ThibaultLacharme ThibaultLacharme force-pushed the ThibaultLacharme:wrench_stamped branch 2 times, most recently from cf5bf25 to 0334782 Aug 29, 2019

@ThibaultLacharme

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

WrenchStamped_Amphion

@ThibaultLacharme ThibaultLacharme force-pushed the ThibaultLacharme:wrench_stamped branch from 27e87a8 to a1b0f2e Sep 9, 2019

@ThibaultLacharme ThibaultLacharme force-pushed the ThibaultLacharme:wrench_stamped branch from a1b0f2e to d69ee24 Sep 9, 2019

@lgtm-com

This comment has been minimized.

Copy link

commented Sep 9, 2019

This pull request introduces 11 alerts when merging d69ee24 into 8216a54 - view on LGTM.com

new alerts:

  • 11 for Unused variable, import, function or class
@lgtm-com

This comment has been minimized.

Copy link

commented Sep 10, 2019

This pull request introduces 10 alerts when merging 87076f8 into 8216a54 - view on LGTM.com

new alerts:

  • 10 for Unused variable, import, function or class

@ThibaultLacharme ThibaultLacharme force-pushed the ThibaultLacharme:wrench_stamped branch 2 times, most recently from d3a5c4f to 2c797ce Sep 10, 2019

@lgtm-com

This comment has been minimized.

Copy link

commented Sep 10, 2019

This pull request introduces 10 alerts when merging 2c797ce into 8216a54 - view on LGTM.com

new alerts:

  • 10 for Unused variable, import, function or class

@ThibaultLacharme ThibaultLacharme force-pushed the ThibaultLacharme:wrench_stamped branch from 2c797ce to 26fae10 Sep 10, 2019

@lgtm-com

This comment has been minimized.

Copy link

commented Sep 10, 2019

This pull request introduces 10 alerts when merging 26fae10 into 8216a54 - view on LGTM.com

new alerts:

  • 10 for Unused variable, import, function or class

@ThibaultLacharme ThibaultLacharme force-pushed the ThibaultLacharme:wrench_stamped branch from 26fae10 to 06779cc Sep 10, 2019

@lgtm-com

This comment has been minimized.

Copy link

commented Sep 10, 2019

This pull request introduces 10 alerts when merging 06779cc into 8216a54 - view on LGTM.com

new alerts:

  • 10 for Unused variable, import, function or class

@ThibaultLacharme ThibaultLacharme changed the title implementation of Wrench (WIP) implementation of Wrench Sep 11, 2019

@tocttou tocttou self-requested a review Sep 13, 2019

@tocttou
Copy link
Collaborator

left a comment

Tested and works. Thanks!
Please use a prettier plugin for your editor: https://prettier.io/docs/en/editors.html

@tocttou tocttou merged commit 9bda803 into rapyuta-robotics:devel Sep 13, 2019

2 checks passed

LGTM analysis: JavaScript 10 new alerts
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.