Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the concept of DataSource to Amphion #81

Merged
merged 24 commits into from Feb 12, 2020
Merged

Conversation

tocttou
Copy link
Contributor

@tocttou tocttou commented Dec 17, 2019

export abstract class DataSource<T> {
  abstract createdAt: Date = new Date();
  abstract hasMemory: boolean;
  abstract resume: () => DataSourceAction;
  abstract pause: () => DataSourceAction;
  abstract addListener: (listener: Listener<T>) => DataSourceAction;
  abstract removeListener: (listener: Listener<T>) => DataSourceAction;
  abstract removeAllListeners: () => DataSourceAction;
}

@tocttou tocttou marked this pull request as ready for review Jan 10, 2020
@tocttou tocttou requested a review from chaitanya-deep Jan 10, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
@rapyuta-robotics rapyuta-robotics deleted a comment from lgtm-com bot Jan 15, 2020
topicName: string;
messageType: string;
memory?: boolean;
compression?: 'png' | 'cbor';
Copy link
Contributor

@chaitanya-deep chaitanya-deep Feb 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Add cbor-raw after next release. RobotWebTools/roslibjs@0fc3d76

@chaitanya-deep chaitanya-deep merged commit be26942 into devel Feb 12, 2020
2 of 3 checks passed
@chaitanya-deep chaitanya-deep deleted the feature/datasource branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants