PointerEventProps #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raquo
reviewed
Jan 20, 2019
| EP, | ||
| dom.Event, | ||
| dom.PointerEvent, | ||
| TypedTargetPointerEvent[dom.Element], |
There was a problem hiding this comment.
This trailing comma is failing Scala 2.11 build
There was a problem hiding this comment.
I fixed the trailing comma. But it looks like i messed up the rebase.
I can re-create the PR if you wish.
…r-event-props # Conflicts: # js/src/main/scala/com/raquo/domtypes/jsdom/defs/package.scala
raquo
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pointer events are now available across all major browsers, since they provide several advantages over traditional mouse and touch events, it would be handy to be able to use them in scala-dom-types.