Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATO-779 Add a note to documentation for fixing Windows character encoding or text colour #12290

Conversation

Urkem
Copy link
Contributor

@Urkem Urkem commented Apr 18, 2023

Proposed changes:

  • Add a note to the CLI documentation page to address encoding/colour issues on certain windows terminals (git bash)
  • Only way to fix ATO-779 (comments for info)

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Urkem Urkem requested review from a team and vcidst and removed request for a team April 18, 2023 15:12
@@ -31,6 +31,12 @@ import RasaProBanner from "@theme/RasaProBanner";
|`rasa evaluate markers` |Extracts markers from an existing tracker store. |
|`rasa -h` |Shows all available commands. |

:::note
If you run into character encoding issues on Windows like: `UnicodeEncodeError: 'charmap' codec can't encode character ...` or
the terminal is not displaying colored messages properly, prepend `winpty` to the command you would like to run.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To address these Typo CI warnings, you can add winpty to this list here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 🙏

Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 could you please add a changelog of type doc?

…cant-encode-character-u-0001-f-916-in-position-17-character-maps-to-undefined
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12290--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@Urkem Urkem merged commit d04f197 into 3.5.x Apr 19, 2023
117 checks passed
@Urkem Urkem deleted the ATO-779-unicode-encode-error-charmap-codec-cant-encode-character-u-0001-f-916-in-position-17-character-maps-to-undefined branch April 19, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants