Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor stacking estimators with class inheritance #444

Open
kota7 opened this issue Sep 24, 2018 · 1 comment · May be fixed by #445

Comments

@kota7
Copy link
Contributor

commented Sep 24, 2018

Currently we have four stacking-based estimators: StackingRegressor and StackingClassifier, and CV variant of each. They are independently coded, while core steps are common.

This makes enhancement work time-consuming, since contributors often need to make similar update on four source code. I would suggest refactoring the four estimators with appropriate class inheritance structure. This will make issues like #439 and #255 much simpler to implement.

@rasbt

This comment has been minimized.

Copy link
Owner

commented Sep 24, 2018

Totally agree. They were implemented one at a time, over time, and the API changed quite a bit based on what's useful and what not. Now after 1-2 years that it's kind of stabilized and they remain pretty similar "core"-wise, it'd be good to consolidate them via a parent Stacking class

@rasbt rasbt added the enhancement label Sep 24, 2018

@rasbt rasbt added this to Enhancements in v 0.14 Roadmap Sep 24, 2018

@kota7 kota7 referenced a pull request that will close this issue Sep 25, 2018
0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.