New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support both scikit-learn 0.19 and 0.20 in unit tests #448

Merged

rasbt merged 2 commits into master from sklearn0.20

Sep 28, 2018

Owner

rasbt commented Sep 28, 2018 •

edited

Description

Makes appropriate changes in unit tests to also support scikit-learn 0.20.

Pull Request Checklist

Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
Checked for style issues by running flake8 ./mlxtend


          support both 0.19 and 0.20 in unit tests

14620ff

pep8speaks commented Sep 28, 2018 •

edited

Hello @rasbt! Thanks for updating the PR.

There are no PEP8 issues in the file mlxtend/classifier/tests/test_ensemble_vote_classifier.py !
There are no PEP8 issues in the file mlxtend/classifier/tests/test_stacking_classifier.py !
There are no PEP8 issues in the file mlxtend/classifier/tests/test_stacking_cv_classifier.py !
There are no PEP8 issues in the file mlxtend/evaluate/tests/test_bootstrap_point632.py !
There are no PEP8 issues in the file mlxtend/evaluate/tests/test_feature_importance.py !
There are no PEP8 issues in the file mlxtend/evaluate/tests/test_holdout.py !
There are no PEP8 issues in the file mlxtend/evaluate/tests/test_paired_ttest_5x2cv.py !
There are no PEP8 issues in the file mlxtend/evaluate/tests/test_paired_ttest_kfold.py !
There are no PEP8 issues in the file mlxtend/evaluate/tests/test_paired_ttest_resampled.py !
There are no PEP8 issues in the file mlxtend/feature_selection/tests/test_column_selector.py !
There are no PEP8 issues in the file mlxtend/feature_selection/tests/test_sequential_feature_selector.py !
There are no PEP8 issues in the file mlxtend/plotting/tests/test_learning_curves.py !
There are no PEP8 issues in the file mlxtend/preprocessing/tests/test_copy_transformer.py !
There are no PEP8 issues in the file mlxtend/preprocessing/tests/test_dense_transformer.py !
There are no PEP8 issues in the file mlxtend/regressor/tests/test_stacking_cv_regression.py !
There are no PEP8 issues in the file mlxtend/regressor/tests/test_stacking_regression.py !

Comment last updated on September 28, 2018 at 06:51 Hours UTC


          fix pep8 issues

3cf1e74

coveralls commented Sep 28, 2018 •

edited

Coverage decreased (-0.1%) to 91.677% when pulling 3cf1e74 on sklearn0.20 into 13b4df6 on master.

rasbt merged commit 7573e4f into master

rasbt deleted the sklearn0.20 branch

November 10, 2018 19:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment