Compatibility broken with socket.io-redis > 0.2.0 #20

Open
ashiina opened this Issue Dec 29, 2015 · 11 comments

Projects

None yet

5 participants

@ashiina
ashiina commented Dec 29, 2015

As of socket.io-redis@0.2.0, the redis channel name and msgpack format has changed. The current socket.io-php-emitter still uses the old format, and does not work at all.

The socket.io-emitter (node.js implementation) has updated its code to make it compatible. The PHP implementation also needs it:
socketio/socket.io-emitter@e656600

@aPoCoMiLogin

+1

@aPoCoMiLogin

Also @ashiina if you can, don't delete your fork, before @rase- will marge your PR, cause i'm using it in my project. Thanks!

@ashiina
ashiina commented Jan 6, 2016

@aPoCoMiLogin no problem! I'm using it too so don't worry

@rodrigoprimo rodrigoprimo added a commit to rodrigoprimo/wceu-2015-presentation-code that referenced this issue Jan 17, 2016
@rodrigoprimo rodrigoprimo Fix compatibility issue by making dependencies versions more specific
The latest version of socket.io-php-emitter (0.7.0) doesn't work socket.io >= 1.4.0 (see rase-/socket.io-php-emitter#20) so this commit changes package.json to force this project to use socket.io version 1.3.*.
c219695
@rodrigoprimo rodrigoprimo added a commit to rodrigoprimo/wceu-2015-presentation-code that referenced this issue Jan 17, 2016
@rodrigoprimo rodrigoprimo Fix compatibility issue by making dependencies versions more specific
The latest version of socket.io-php-emitter (0.7.0) doesn't work with socket.io >= 1.4.0 (see rase-/socket.io-php-emitter#20). So this commit changes package.json to force this project to use socket.io version 1.3.*.
cab2b89
@rodrigoprimo

+1

@jihunleekr

+1

@jihunleekr

@aPoCoMiLogin How can I use @ashiina 's PR? I'm just copy&pasted on @rase- 's. It works but I don't like this method.

@aPoCoMiLogin

@jihunleekr my composer.json looks like this:

{
    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/ashiina/socket.io-php-emitter.git"
        }
    ],
    "require": {
        "rase/socket.io-emitter": "dev-hotfix/redis-0.2.0-compatibility"
    }
}

So you have to add repositories collection with @ashiina repository, and in require section you have to add dev-{branch}/{commit/PR}

IMO npm is doing it better than composer.

@jihunleekr

@aPoCoMiLogin Thank you. It is very helpful. :)

@lukepolo
lukepolo commented May 7, 2016

please merge

@ashiina
ashiina commented May 29, 2016

Seems like this repo isn't being maintained for a long time...
Everyone please go ahead and use my fork https://github.com/ashiina/socket.io-php-emitter , on the hotfix/redis-0.2.0-compatibility branch . I will try to maintain it.

Please refer to aPoCoMiLogin 's comment on how to use it via composer.

@ashiina ashiina referenced this issue in ashiina/socket.io-php-emitter Jun 6, 2016
Merged

Hotfix/redis 0.2.0 compatibility #1

@ashiina
ashiina commented Jun 6, 2016

I now added my fork on packagist here
https://packagist.org/packages/ashiina/socket.io-emitter

Please go ahead and use this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment