Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility broken with socket.io-redis > 0.2.0 #20

Open
ashiina opened this issue Dec 29, 2015 · 11 comments
Open

Compatibility broken with socket.io-redis > 0.2.0 #20

ashiina opened this issue Dec 29, 2015 · 11 comments

Comments

@ashiina
Copy link

@ashiina ashiina commented Dec 29, 2015

As of socket.io-redis@0.2.0, the redis channel name and msgpack format has changed. The current socket.io-php-emitter still uses the old format, and does not work at all.

The socket.io-emitter (node.js implementation) has updated its code to make it compatible. The PHP implementation also needs it:
socketio/socket.io-redis-emitter@e656600

@aPoCoMiLogin
Copy link

@aPoCoMiLogin aPoCoMiLogin commented Dec 30, 2015

+1

@aPoCoMiLogin
Copy link

@aPoCoMiLogin aPoCoMiLogin commented Dec 30, 2015

Also @ashiina if you can, don't delete your fork, before @rase- will marge your PR, cause i'm using it in my project. Thanks!

@ashiina
Copy link
Author

@ashiina ashiina commented Jan 6, 2016

@aPoCoMiLogin no problem! I'm using it too so don't worry

rodrigoprimo referenced this issue in rodrigoprimo/wceu-2015-presentation-code Jan 17, 2016
The latest version of socket.io-php-emitter (0.7.0) doesn't work socket.io >= 1.4.0 (see https://github.com/rase-/socket.io-php-emitter/issues/20) so this commit changes package.json to force this project to use socket.io version 1.3.*.
rodrigoprimo referenced this issue in rodrigoprimo/wceu-2015-presentation-code Jan 17, 2016
The latest version of socket.io-php-emitter (0.7.0) doesn't work with socket.io >= 1.4.0 (see https://github.com/rase-/socket.io-php-emitter/issues/20). So this commit changes package.json to force this project to use socket.io version 1.3.*.
@rodrigoprimo
Copy link

@rodrigoprimo rodrigoprimo commented Jan 17, 2016

+1

1 similar comment
@jihunleekr
Copy link

@jihunleekr jihunleekr commented Feb 4, 2016

+1

@jihunleekr
Copy link

@jihunleekr jihunleekr commented Feb 4, 2016

@aPoCoMiLogin How can I use @ashiina 's PR? I'm just copy&pasted on @rase- 's. It works but I don't like this method.

@aPoCoMiLogin
Copy link

@aPoCoMiLogin aPoCoMiLogin commented Feb 4, 2016

@jihunleekr my composer.json looks like this:

{
    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/ashiina/socket.io-php-emitter.git"
        }
    ],
    "require": {
        "rase/socket.io-emitter": "dev-hotfix/redis-0.2.0-compatibility"
    }
}

So you have to add repositories collection with @ashiina repository, and in require section you have to add dev-{branch}/{commit/PR}

IMO npm is doing it better than composer.

@jihunleekr
Copy link

@jihunleekr jihunleekr commented Feb 5, 2016

@aPoCoMiLogin Thank you. It is very helpful. :)

@lukepolo
Copy link

@lukepolo lukepolo commented May 7, 2016

please merge

@ashiina
Copy link
Author

@ashiina ashiina commented May 29, 2016

Seems like this repo isn't being maintained for a long time...
Everyone please go ahead and use my fork https://github.com/ashiina/socket.io-php-emitter , on the hotfix/redis-0.2.0-compatibility branch . I will try to maintain it.

Please refer to aPoCoMiLogin 's comment on how to use it via composer.

@ashiina
Copy link
Author

@ashiina ashiina commented Jun 6, 2016

I now added my fork on packagist here
https://packagist.org/packages/ashiina/socket.io-emitter

Please go ahead and use this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants