Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed Etcher to balenaEtcher and etcher.io to www.balena.com/etcher/ #1085

Merged
merged 4 commits into from Jul 18, 2019
Merged

Conversation

gmkey
Copy link
Contributor

@gmkey gmkey commented Feb 14, 2019

made the modifications for all affected pages rather than one. closed #1084, which - in the event you approve the change - contained only one affected page

@JamesH65
Copy link
Contributor

There appear to be a number of whitespace related changes unrelated tothe balena change. I'd prefer, if possible, that they supplied as a separate PR, since that makes it easier to detemine relevent changes. Still waiting for confirmation from Balena themselves on the correct naming scheme.

@gmkey
Copy link
Contributor Author

gmkey commented Feb 14, 2019

Oh dear, that seems to be the setting on my text editor (Atom). Not sure how to revert these? (not that github prolific for that matter. Please advise

@JamesH65
Copy link
Contributor

Hmm, not sure of your procedure, but I'd revert the whitespace changes, then use git commit --amend to update the PR. Or, make another PR that just has the whitespace changes in, send that in, then rebase this PR with that one. Or something.

@lurch
Copy link
Contributor

lurch commented Feb 14, 2019

Ping @thundron and @zvin (and see also #1084, where this was also discussed)

@JamesH65
Copy link
Contributor

Part of the problem is that balenaEtcher is such an awkward (and terrible) name. Everyone is still just going to call it Etcher (a great name) whatever its actual name is, and changing the docs might make it more confusing rather than less.

@bennuttall
Copy link
Contributor

bennuttall commented Feb 15, 2019

FWIW etcher.io was a better URL too

@lurch
Copy link
Contributor

lurch commented Feb 15, 2019

@JamesH65 See also "GNU/Linux" and "Microsoft Windows" 😉 (which everyone calls just Linux and Windows)

@gmkey
Copy link
Contributor Author

gmkey commented Feb 15, 2019

I agree with most your comments and I do feel that some marketing intern at etcher has probably forgot to read branding 101.
At the same time most of the target Community are inexperienced, the name could set them of on the wrong foot.
IMHO waiting for a statement from etcher / baloney (err balena ;-) is the sensible thing to do.

@gmkey
Copy link
Contributor Author

gmkey commented Feb 15, 2019

PS “GNU/Linux” is actually a name given to the Linux project by the FSF. AFAIK the Linux Project at kernel.org talk only about Linux.

@lurch
Copy link
Contributor

lurch commented Feb 15, 2019

Ping also @jviotti and @alexandrosm

@JamesH65
Copy link
Contributor

Going to merge this with the whitespace changes as well - bit confusing, but they need to be done anyway.

@JamesH65 JamesH65 merged commit 1ea24d2 into raspberrypi:master Jul 18, 2019
@gmkey gmkey deleted the patch-2 branch July 18, 2019 11:18
@lurch
Copy link
Contributor

lurch commented Jul 18, 2019

@JamesH65 Something seems to have gone awry with your merge here 😕
Prior to this, the glossary mentioned BCM2711, but that's now gone in the current version ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants