New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renamed Etcher to balenaEtcher and etcher.io to www.balena.com/etcher/ #1085
Conversation
There appear to be a number of whitespace related changes unrelated tothe balena change. I'd prefer, if possible, that they supplied as a separate PR, since that makes it easier to detemine relevent changes. Still waiting for confirmation from Balena themselves on the correct naming scheme. |
Oh dear, that seems to be the setting on my text editor (Atom). Not sure how to revert these? (not that github prolific for that matter. Please advise |
Hmm, not sure of your procedure, but I'd revert the whitespace changes, then use git commit --amend to update the PR. Or, make another PR that just has the whitespace changes in, send that in, then rebase this PR with that one. Or something. |
Part of the problem is that balenaEtcher is such an awkward (and terrible) name. Everyone is still just going to call it Etcher (a great name) whatever its actual name is, and changing the docs might make it more confusing rather than less. |
FWIW etcher.io was a better URL too |
@JamesH65 See also "GNU/Linux" and "Microsoft Windows" 😉 (which everyone calls just Linux and Windows) |
I agree with most your comments and I do feel that some marketing intern at etcher has probably forgot to read branding 101. |
PS “GNU/Linux” is actually a name given to the Linux project by the FSF. AFAIK the Linux Project at kernel.org talk only about Linux. |
Ping also @jviotti and @alexandrosm |
Going to merge this with the whitespace changes as well - bit confusing, but they need to be done anyway. |
@JamesH65 Something seems to have gone awry with your merge here 😕 |
made the modifications for all affected pages rather than one. closed #1084, which - in the event you approve the change - contained only one affected page