Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

OMX_GetParameter OMX_IndexParamVideoBitrate set zeros version, size, port #163

Open
xlazom00 opened this Issue · 11 comments

5 participants

@xlazom00

OMX_VIDEO_PARAM_BITRATETYPE bitrate_param;

GST_OMX_INIT_STRUCT (&bitrate_param); // set up to init values
bitrate_param.nPortIndex = self->enc_out_port->index;

OMX_ERRORTYPE err;
err = OMX_GetParameter (self->enc->handle, OMX_IndexParamVideoBitrate, &bitrate_param);

OMX_GetParameter return zero in version, size, port
It should return same port I setup up before OMX_GetParameter
right version and size

some frameworks like gst-omx use get/set mechanism for initialization

@sdroege

And if getting that parameter is not supported the corresponding error should be returned

@popcornmix
Owner

Getting this parameter is supported (by video_encode). OpenMax guy says this does work in general.
Can you provide an example that shows the problem (e.g. by editing hello_encode example).
Is an error response set?

@xlazom00

OMX_VIDEO_PARAM_BITRATETYPE bitrate_param;

// set up to init values like version, size , port,...
bitrate_param.nSize = sizeof(OMX_VIDEO_PARAM_PORTFORMATTYPE);
bitrate_param.nVersion.nVersion = OMX_VERSION;
GST_OMX_INIT_STRUCT (&bitrate_param);
bitrate_param.nPortIndex = 201;

But after this
OMX_GetParameter (self->enc->handle, OMX_IndexParamVideoBitrate, &bitrate_param);

all values in bitrate_param looks like after
memset(&bitrateType, 0, sizeof(OMX_VIDEO_PARAM_BITRATETYPE));

nSize == 0 nVersion ==0 , nPortIndex == 0,....
OMX accept values but zero buffer.

@popcornmix
Owner

@xlazom00
You've just repeated your first message. Can you produce a self contained example that exhibit your problem.
It should be possible to trivially modify hello_encode to do this.

@popcornmix
Owner

@xlazom00
Thanks, I'll pass it on.

@popcornmix
Owner

Confirmed. A bug report is opened in our jira bugtracker.

@Ruffio

@popcornmix has this been resolved in the jira bugtracker?

@popcornmix
Owner

Pretty sure this has been fixed. @xlazom00 can you still reproduce this?

@6by9

Just looking at the source and I don't think this is fixed.
nSize an nVersion aren't set by default in the component, and getParameter copies port->video_bitrate in its entirety, so returns 0 for those fields. Two line patch required I think - @popcornmix I'll ping it through to you.

@popcornmix popcornmix referenced this issue from a commit
@popcornmix popcornmix kernel: BCM270X_DT: Add MCP7941X to i2c-rtc overlay
kernel: bcm2708-spi: Don't use static pin configuration with DT

kernel: bcm2708-i2s: Don't use static pin configuration with DT

kernel: gpio-poweroff: Allow it to work on Raspberry Pi
See: raspberrypi/linux#1031

kernel: BCM270X_DT: Create a core clock, use it for SPI and sdhost

kernel: BCM270X_DT: Add overlay to enable uart1
See: raspberrypi/linux#1008

kernel: config: Enable ZSMALLOC, ZRAM and PGTABLE_MAPPING
See: Hexxeh/rpi-firmware#85

firmware: arm_loader: Support initialising vchiq through mailbox property interface
See: raspberrypi/linux#1026

firmware: drivers/usb: Reduce busy-wait to sensible timeout
See: raspberrypi/linux#1026

firmware: video_encode: Initialise headers for video_bitrate
See: #163

firmware: arm_loader: Use the new core_freq DT parameter if present

firmware: arm_loader: Set the uart1_clkrate DT property from core_freq

firmware: arm_cursor: Better handling of a second app requesting a cursor

firmware: arm: Tidy up setting of arm_control and arm_bash
df32073
@popcornmix popcornmix referenced this issue from a commit in Hexxeh/rpi-firmware
@popcornmix popcornmix kernel: BCM270X_DT: Add MCP7941X to i2c-rtc overlay
kernel: bcm2708-spi: Don't use static pin configuration with DT

kernel: bcm2708-i2s: Don't use static pin configuration with DT

kernel: gpio-poweroff: Allow it to work on Raspberry Pi
See: raspberrypi/linux#1031

kernel: BCM270X_DT: Create a core clock, use it for SPI and sdhost

kernel: BCM270X_DT: Add overlay to enable uart1
See: raspberrypi/linux#1008

kernel: config: Enable ZSMALLOC, ZRAM and PGTABLE_MAPPING
See: #85

firmware: arm_loader: Support initialising vchiq through mailbox property interface
See: raspberrypi/linux#1026

firmware: drivers/usb: Reduce busy-wait to sensible timeout
See: raspberrypi/linux#1026

firmware: video_encode: Initialise headers for video_bitrate
See: raspberrypi/firmware#163

firmware: arm_loader: Use the new core_freq DT parameter if present

firmware: arm_loader: Set the uart1_clkrate DT property from core_freq

firmware: arm_cursor: Better handling of a second app requesting a cursor

firmware: arm: Tidy up setting of arm_control and arm_bash
baabb60
@popcornmix
Owner

I've added @6by9's patch in latest rpi-update - does that help?

@6by9 6by9 referenced this issue in Hexxeh/rpi-firmware
Closed

firmware bitrate header breaks gst use #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.