Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Update paths to ilclient and vgfont in Makefile.include #153

Open
wants to merge 2 commits into from

1 participant

@fieldOfView

If a user wants to make an application based on the hello_pi example code, he/she may want to use Makefile.include as per the sample code. Currently this works, provided that the user puts the source of the new application in the /opt/vc/src/hello_pi/ tree, or the user does not use ilclient and vgfont. If the user includes either of those libraries when the project is not in said filesystem tree, the compiler will not find the library because Makefile.include specifies a relative path to the libraries.

This pull request makes paths to ilclient and vgfont absolute so Makefile.include can be included from other locations in the filesystem.

fieldOfView added some commits
@fieldOfView fieldOfView Update Makefile.include
Make paths to ilclient and vgfont absolute so Makefile.include can be included from other locations in the filesystem
42347c7
@fieldOfView fieldOfView Update Makefile.include
Include $(SDKSTAGE) in link paths per suggestion by @popcornmix
3e59557
@fieldOfView

I see having a Makefile.include with working paths as a convenience for people writing (example) code based on the included examples. The current design leads to people writing their own Makefile which does not conform to the hello_pi Makefiles, which then "run the risk" of getting merged into the example code as is.

The Makefile of the hello_videocube example is a good example of how this leads to possibly harder to maintain code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 4, 2013
  1. @fieldOfView

    Update Makefile.include

    fieldOfView authored
    Make paths to ilclient and vgfont absolute so Makefile.include can be included from other locations in the filesystem
  2. @fieldOfView

    Update Makefile.include

    fieldOfView authored
    Include $(SDKSTAGE) in link paths per suggestion by @popcornmix
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 3 deletions.
  1. +2 −3 opt/vc/src/hello_pi/Makefile.include
View
5 opt/vc/src/hello_pi/Makefile.include
@@ -1,9 +1,8 @@
-
CFLAGS+=-DSTANDALONE -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS -DTARGET_POSIX -D_LINUX -fPIC -DPIC -D_REENTRANT -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -U_FORTIFY_SOURCE -Wall -g -DHAVE_LIBOPENMAX=2 -DOMX -DOMX_SKIP64BIT -ftree-vectorize -pipe -DUSE_EXTERNAL_OMX -DHAVE_LIBBCM_HOST -DUSE_EXTERNAL_LIBBCM_HOST -DUSE_VCHIQ_ARM -Wno-psabi
-LDFLAGS+=-L$(SDKSTAGE)/opt/vc/lib/ -lGLESv2 -lEGL -lopenmaxil -lbcm_host -lvcos -lvchiq_arm -lpthread -lrt -L../libs/ilclient -L../libs/vgfont
+LDFLAGS+=-L$(SDKSTAGE)/opt/vc/lib/ -lGLESv2 -lEGL -lopenmaxil -lbcm_host -lvcos -lvchiq_arm -lpthread -lrt -L$(SDKSTAGE)/opt/vc/src/hello_pi/libs/ilclient -L$(SDKSTAGE)/opt/vc/src/hello_pi/libs/vgfont
-INCLUDES+=-I$(SDKSTAGE)/opt/vc/include/ -I$(SDKSTAGE)/opt/vc/include/interface/vcos/pthreads -I$(SDKSTAGE)/opt/vc/include/interface/vmcs_host/linux -I./ -I../libs/ilclient -I../libs/vgfont
+INCLUDES+=-I$(SDKSTAGE)/opt/vc/include/ -I$(SDKSTAGE)/opt/vc/include/interface/vcos/pthreads -I$(SDKSTAGE)/opt/vc/include/interface/vmcs_host/linux -I./ -I$(SDKSTAGE)/opt/vc/src/hello_pi/libs/ilclient -I$(SDKSTAGE)/opt/vc/src/hello_pi/libs/vgfont
all: $(BIN) $(LIB)
Something went wrong with that request. Please try again.