Browse files

vhost: don't forget to schedule()

commit d550dda upstream.

This is a tiny, but important, patch to vhost.

Vhost's worker thread only called schedule() when it had no work to do, and
it wanted to go to sleep. But if there's always work to do, e.g., the guest
is running a network-intensive program like netperf with small message sizes,
schedule() was *never* called. This had several negative implications (on
non-preemptive kernels):

 1. Passing time was not properly accounted to the "vhost" process (ps and
    top would wrongly show it using zero CPU time).

 2. Sometimes error messages about RCU timeouts would be printed, if the
    core running the vhost thread didn't schedule() for a very long time.

 3. Worst of all, a vhost thread would "hog" the core. If several vhost
    threads need to share the same core, typically one would get most of the
    CPU time (and its associated guest most of the performance), while the
    others hardly get any work done.

The trivial solution is to add

	if (need_resched())

After doing every piece of work. This will not do the heavy schedule() all
the time, just when the timer interrupt decided a reschedule is warranted
(so need_resched returns true).

Thanks to Abel Gordon for this patch.

Signed-off-by: Nadav Har'El <>
Signed-off-by: Michael S. Tsirkin <>
Signed-off-by: Ben Hutchings <>
  • Loading branch information...
1 parent 51326e0 commit 1803c9c9746dd5cd524d6499ca24cbb4eacffa37 Nadav Har'El committed with bwhacks Feb 27, 2012
Showing with 2 additions and 0 deletions.
  1. +2 −0 drivers/vhost/vhost.c
@@ -222,6 +222,8 @@ static int vhost_worker(void *data)
if (work) {
+ if (need_resched())
+ schedule();
} else

0 comments on commit 1803c9c

Please sign in to comment.