Navigation Menu

Skip to content

Commit

Permalink
openvswitch:: link upper device for port devices
Browse files Browse the repository at this point in the history
Link upper device properly. That will make IFLA_MASTER filled up.
Set the master to port 0 of the datapath under which the port belongs.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Jesse Gross <jesse@nicira.com>
  • Loading branch information
jpirko authored and jessegross committed Aug 23, 2013
1 parent 76a66c7 commit 2537b4d
Showing 1 changed file with 19 additions and 1 deletion.
20 changes: 19 additions & 1 deletion net/openvswitch/vport-netdev.c
Expand Up @@ -25,6 +25,7 @@
#include <linux/llc.h>
#include <linux/rtnetlink.h>
#include <linux/skbuff.h>
#include <linux/openvswitch.h>

#include <net/llc.h>

Expand Down Expand Up @@ -74,6 +75,15 @@ static rx_handler_result_t netdev_frame_hook(struct sk_buff **pskb)
return RX_HANDLER_CONSUMED;
}

static struct net_device *get_dpdev(struct datapath *dp)
{
struct vport *local;

local = ovs_vport_ovsl(dp, OVSP_LOCAL);
BUG_ON(!local);
return netdev_vport_priv(local)->dev;
}

static struct vport *netdev_create(const struct vport_parms *parms)
{
struct vport *vport;
Expand Down Expand Up @@ -103,17 +113,24 @@ static struct vport *netdev_create(const struct vport_parms *parms)
}

rtnl_lock();
err = netdev_master_upper_dev_link(netdev_vport->dev,
get_dpdev(vport->dp));
if (err)
goto error_unlock;

err = netdev_rx_handler_register(netdev_vport->dev, netdev_frame_hook,
vport);
if (err)
goto error_unlock;
goto error_master_upper_dev_unlink;

dev_set_promiscuity(netdev_vport->dev, 1);
netdev_vport->dev->priv_flags |= IFF_OVS_DATAPATH;
rtnl_unlock();

return vport;

error_master_upper_dev_unlink:
netdev_upper_dev_unlink(netdev_vport->dev, get_dpdev(vport->dp));
error_unlock:
rtnl_unlock();
error_put:
Expand All @@ -140,6 +157,7 @@ static void netdev_destroy(struct vport *vport)
rtnl_lock();
netdev_vport->dev->priv_flags &= ~IFF_OVS_DATAPATH;
netdev_rx_handler_unregister(netdev_vport->dev);
netdev_upper_dev_unlink(netdev_vport->dev, get_dpdev(vport->dp));
dev_set_promiscuity(netdev_vport->dev, -1);
rtnl_unlock();

Expand Down

0 comments on commit 2537b4d

Please sign in to comment.