HTTPS clone URL
Subversion checkout URL
Please sign in to comment.
mm: mmu_notifier: fix freed page still mapped in secondary MMU
commit 3ad3d90 upstream. mmu_notifier_release() is called when the process is exiting. It will delete all the mmu notifiers. But at this time the page belonging to the process is still present in page tables and is present on the LRU list, so this race will happen: CPU 0 CPU 1 mmu_notifier_release: try_to_unmap: hlist_del_init_rcu(&mn->hlist); ptep_clear_flush_notify: mmu nofifler not found free page !!!!!! /* * At the point, the page has been * freed, but it is still mapped in * the secondary MMU. */ mn->ops->release(mn, mm); Then the box is not stable and sometimes we can get this bug: [ 738.075923] BUG: Bad page state in process migrate-perf pfn:03bec [ 738.075931] page:ffffea00000efb00 count:0 mapcount:0 mapping: (null) index:0x8076 [ 738.075936] page flags: 0x20000000000014(referenced|dirty) The same issue is present in mmu_notifier_unregister(). We can call ->release before deleting the notifier to ensure the page has been unmapped from the secondary MMU before it is freed. Signed-off-by: Xiao Guangrong <firstname.lastname@example.org> Cc: Avi Kivity <email@example.com> Cc: Marcelo Tosatti <firstname.lastname@example.org> Cc: Paul Gortmaker <email@example.com> Cc: Andrea Arcangeli <firstname.lastname@example.org> Signed-off-by: Andrew Morton <email@example.com> Signed-off-by: Linus Torvalds <firstname.lastname@example.org> Signed-off-by: Ben Hutchings <email@example.com>
- Loading branch information...
1 parent 3927df7 commit 5d7a60687ef06b2de46f4d2415863a2dffae96e5 Xiao Guangrong committed with Ben Hutchings