Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bcm2835-pcm.c: Support multichannel audio
- Loading branch information
1 parent
19b8d94
commit 9a47172
Showing
1 changed file
with
9 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a47172
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some reason that channels_max, buffer_bytes_max and period_bytes_max were not updated in snd_bcm2835_playback_hw?
9a47172
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I'm not sure why. Have you tested with that change?
9a47172
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes on Model 4B. See https://www.diyaudio.com/forums/pc-based/334443-2-8-dsp-platform-using-raspberry-pi-hats-10.html
It appears earlier Pi models use snd_bcm2835_playback_spdif_hw struct and therefore 8-channel audio works over HDMI (thanks to this commit) but the 4B needs the other struct modified as well.
9a47172
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See: #3933
9a47172
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, posted to wrong thread #3933 (comment)