Browse files

parport_pc: release IO region properly if unsupported ITE887x card is…

… found

sio_ite_8872_probe() bails out if it detects no-parallel (1S, 2S) or
unknown card.

It doesn't call release_region() on the previously allocated resource
though.  This causes

  (a) leak of the resource
  (b) kernel oops when parport module is removed and /proc/ioports is read. This
      is because the string that has been associated to the IO port region
      is a static char array inside the already removed module.

Let's call release_region() properly before baling out.

Signed-off-by: Jiri Kosina <>
Acked-by: Niels de Vos <>
Cc: Bjorn Helgaas <>
Cc: Alan Cox <>
Cc: Joe Krahn <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Greg Kroah-Hartman <>
  • Loading branch information...
1 parent 8193c42 commit 9fdbdd062bfc187e2aa32f7880fa7e8ae717efdf Jiri Kosina committed with gregkh Oct 6, 2011
Showing with 3 additions and 0 deletions.
  1. +3 −0 drivers/parport/parport_pc.c
3 drivers/parport/parport_pc.c
@@ -2595,14 +2595,17 @@ static int __devinit sio_ite_8872_probe(struct pci_dev *pdev, int autoirq,
case 0x6:
printk(KERN_INFO "parport_pc: ITE8873 found (1S)\n");
+ release_region(inta_addr[i], 32);
return 0;
case 0x8:
printk(KERN_INFO "parport_pc: ITE8874 found (2S)\n");
+ release_region(inta_addr[i], 32);
return 0;
printk(KERN_INFO "parport_pc: unknown ITE887x\n");
printk(KERN_INFO "parport_pc: please mail 'lspci -nvv' "
"output to\n");
+ release_region(inta_addr[i], 32);
return 0;

0 comments on commit 9fdbdd0

Please sign in to comment.