Skip to content
Browse files

export_report: use warn() to issue WARNING, so they go to stderr

Also count CONFIG_MODVERSIONS warnings, and print a NOTE at start of
SECTION 2 if any were issued.  Section 2 will be empty if the build is
lacking this CONFIG_ item, and user may have missed the warnings, as
they're off screen.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>
  • Loading branch information...
1 parent bdabc7a commit ca995cbf77f3df599b7e751c2d08d90787c65c45 @jimc jimc committed with michal42 May 23, 2011
Showing with 7 additions and 1 deletion.
  1. +7 −1 scripts/export_report.pl
View
8 scripts/export_report.pl
@@ -102,6 +102,8 @@ sub collectcfiles {
#
# collect the usage count of each symbol.
#
+my $modversion_warnings = 0;
+
foreach my $thismod (@allcfiles) {
my $module;
@@ -132,7 +134,8 @@ sub collectcfiles {
}
}
if ($state != 2) {
- print "WARNING:$thismod is not built with CONFIG_MODVERSION enabled\n";
+ warn "WARNING:$thismod is not built with CONFIG_MODVERSIONS enabled\n";
+ $modversion_warnings++;
}
close($module);
}
@@ -166,6 +169,9 @@ sub collectcfiles {
modules. Each module lists the modules, and the symbols from that module that
it uses. Each listed symbol reports the number of modules using it\n");
+print "\nNOTE: Got $modversion_warnings CONFIG_MODVERSIONS warnings\n\n"
+ if $modversion_warnings;
+
print "~"x80 , "\n";
for my $thismod (sort keys %MODULE) {
my $list = $MODULE{$thismod};

0 comments on commit ca995cb

Please sign in to comment.
Something went wrong with that request. Please try again.