Browse files

ACPI/AC: prevent OOPS on some boxes due to missing check power_supply…

…_register() return value check

In the ac.c, power_supply_register()'s return value is not checked.

As a result, the driver's add() ops may return success
even though the device failed to initialize.

For example, some BIOS may describe two ACADs in the same DSDT.
The second ACAD device will fail to register,
but ACPI driver's add() ops returns sucessfully.
The ACPI device will receive ACPI notification and cause OOPS.

Signed-off-by: Lan Tianyu <>
Signed-off-by: Len Brown <>
  • Loading branch information...
Lan Tianyu authored and lenb committed Jul 20, 2012
1 parent 28a33cb commit f197ac13f6eeb351b31250b9ab7d0da17434ea36
Showing with 3 additions and 1 deletion.
  1. +3 −1 drivers/acpi/ac.c
@@ -292,7 +292,9 @@ static int acpi_ac_add(struct acpi_device *device)
ac-> = ac_props;
ac->charger.num_properties = ARRAY_SIZE(ac_props);
ac->charger.get_property = get_ac_property;
- power_supply_register(&ac->device->dev, &ac->charger);
+ result = power_supply_register(&ac->device->dev, &ac->charger);
+ if (result)
+ goto end;
printk(KERN_INFO PREFIX "%s [%s] (%s)\n",
acpi_device_name(device), acpi_device_bid(device),

0 comments on commit f197ac1

Please sign in to comment.