Skip to content
Permalink
Browse files

bcm2708_fb: Fix layout of struct vc4_display_settings_t

The display parameters returned by the VC4 firmware in response to the
RPI_FIRMWARE_FRAMEBUFFER_GET_DISPLAY_SETTINGS tag do not match the
layout of struct vc4_display_settings_t: the colour depth and row
pitch are erroneously swapped in the kernel definition.  This can
trigger a kernel warning from pixel_to_pat(), such as:

  pixel_to_pat(): unsupported pixelformat 7296

Fix by adjusting the layout of struct vc4_display_settings_t to match
the layout as used by the VC4 firmware.

Signed-off-by: Michael Brown <mbrown@fensystems.co.uk>
  • Loading branch information...
mcb30 authored and pelwell committed Sep 22, 2019
1 parent 6d8bf28 commit f45a2623f5132a2f557adbbf4f37886a403990ec
Showing with 1 addition and 1 deletion.
  1. +1 −1 drivers/video/fbdev/bcm2708_fb.c
@@ -89,8 +89,8 @@ struct vc4_display_settings_t {
u32 display_num;
u32 width;
u32 height;
u32 pitch;
u32 depth;
u32 pitch;
u32 virtual_width;
u32 virtual_height;
u32 virtual_width_offset;

0 comments on commit f45a262

Please sign in to comment.
You can’t perform that action at this time.