spi/spi-bcm2708: respect per-transfer SPI clock speed_hz value #146

Merged
merged 1 commit into from Nov 4, 2012

Conversation

Projects
None yet
3 participants
Contributor

kamalmostafa commented Oct 28, 2012

The bcm2708 SPI driver's bcm2708_process_transfer() was ignoring the
per-transfer speed_hz value even when it was provided (it always just
used the spi device's max_speed_hz value). Now, per-transfer speed_hz
values are respected.

Also added debug print to bcm2708_setup_state() to help keep an eye on
the configured SPI parameters.

Signed-off-by: Kamal Mostafa kamal@whence.com

@kamalmostafa kamalmostafa spi/spi-bcm2708: respect per-transfer SPI clock speed_hz value
The bcm2708 SPI driver's bcm2708_process_transfer() was ignoring the
per-transfer speed_hz value even when it was provided (it always just
used the spi device's max_speed_hz value).  Now, per-transfer speed_hz
values are respected.

Also added debug print to bcm2708_setup_state() to help keep an eye on
the configured SPI parameters.

Signed-off-by: Kamal Mostafa <kamal@whence.com>
06165b5

dpslwk commented Nov 1, 2012

This looks like just the fix I need, now to try compiling my own kernel.

@popcornmix popcornmix added a commit that referenced this pull request Nov 4, 2012

@popcornmix popcornmix Merge pull request #146 from kamalmostafa/rpi-patches
spi/spi-bcm2708: respect per-transfer SPI clock speed_hz value
8fa2e19

@popcornmix popcornmix merged commit 8fa2e19 into raspberrypi:rpi-patches Nov 4, 2012

notro referenced this pull request Jan 22, 2013

Closed

SPI patch missing from 3.6.y #198

@anholt anholt pushed a commit to anholt/linux that referenced this pull request Apr 14, 2016

Andrew Morton + Stephen Rothwell mm-oom-rework-oom-detection-checkpatch-fixes
Cc: David Rientjes <rientjes@google.com>

WARNING: line over 80 characters
#99: FILE: mm/page_alloc.c:2965:
+ * zone list (with a backoff mechanism which is a function of no_progress_loops).

WARNING: line over 80 characters
#129: FILE: mm/page_alloc.c:2995:
+	 * Keep reclaiming pages while there is a chance this will lead somewhere.

WARNING: line over 80 characters
#134: FILE: mm/page_alloc.c:3000:
+	for_each_zone_zonelist_nodemask(zone, z, ac->zonelist, ac->high_zoneidx, ac->nodemask) {

WARNING: line over 80 characters
#138: FILE: mm/page_alloc.c:3004:
+		available -= DIV_ROUND_UP(no_progress_loops * available, MAX_RECLAIM_RETRIES);

WARNING: line over 80 characters
#142: FILE: mm/page_alloc.c:3008:
+		 * Would the allocation succeed if we reclaimed the whole available?

WARNING: line over 80 characters
#146: FILE: mm/page_alloc.c:3012:
+			/* Wait for some write requests to complete then retry */

total: 0 errors, 6 warnings, 202 lines checked

./patches/mm-oom-rework-oom-detection.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: David Rientjes <rientjes@google.com>
Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
5a9a24c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment