Skip to content

Add device tree config for htu21 #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rumpelsepp wants to merge 1 commit into from
Closed

Add device tree config for htu21 #2041

rumpelsepp wants to merge 1 commit into from

Conversation

@rumpelsepp
Copy link
Contributor

@rumpelsepp rumpelsepp commented May 29, 2017

No description provided.

@pelwell
Copy link
Contributor

pelwell commented May 30, 2017

That's a good start. Can you:

  1. Keep the sensors in alphabetical order.
  2. Add htu21 to the README (try dtoverlay -h i2c-sensor in a shell). Stick the the strict whitespace rules - no TABs, same indentation.

If you fix those in one or more follow-up commits we can squash them when merging.

@rumpelsepp
Copy link
Contributor Author

rumpelsepp commented May 30, 2017

Updated.

@pelwell
Copy link
Contributor

pelwell commented May 30, 2017

Your README entry says the default address is 0x40. Can the device have other addresses? If so, we should make the addresses selectable through a parameter. If not, you should remove the word "default".

@rumpelsepp
Copy link
Contributor Author

rumpelsepp commented May 30, 2017

Your README entry says the default address is 0x40. Can the device have other addresses? If so, we should make the addresses selectable through a parameter. If not, you should remove the word "default".

I will check this and report back, can't remember it atm.

@rumpelsepp
Copy link
Contributor Author

rumpelsepp commented May 30, 2017

It seems, that the address is hardcoded: https://cdn-shop.adafruit.com/datasheets/1899_HTU21D.pdf

I will remove the address configuration opportunity.

@pelwell
Copy link
Contributor

pelwell commented May 31, 2017

You need the parameter, otherwise there is no way to select your sensor. Put the parameter back, leave everything else as it is and I'll merge it.

@pelwell
Copy link
Contributor

pelwell commented May 31, 2017

The i2c-sensor overlay has now been restructured internally, breaking your PR. I'll patch it up and merge by hand.

@rumpelsepp
Copy link
Contributor Author

rumpelsepp commented May 31, 2017

Oh nice, thanks! Then I can close this?

@pelwell
Copy link
Contributor

pelwell commented May 31, 2017

I'll do it when I've finished - give me a few minutes.

@rumpelsepp
Copy link
Contributor Author

rumpelsepp commented May 31, 2017

No need to hurry. :) thanks!

pelwell pushed a commit that referenced this pull request May 31, 2017
Add device tree config for htu21
e5bd734 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
@pelwell
Copy link
Contributor

pelwell commented May 31, 2017

Merged manually.

@pelwell pelwell closed this May 31, 2017
pelwell pushed a commit that referenced this pull request Jul 10, 2017
Add device tree config for htu21
842b983 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
pelwell pushed a commit that referenced this pull request Jul 10, 2017
Add device tree config for htu21
e1a9ee4 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Jul 12, 2017
@popcornmix
Add device tree config for htu21
15552f0 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Jul 13, 2017
@popcornmix
Add device tree config for htu21
3881b40 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Jul 13, 2017
@popcornmix
Add device tree config for htu21
d769868 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Jul 16, 2017
@popcornmix
Add device tree config for htu21
8b90d01 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Jul 16, 2017
@popcornmix
Add device tree config for htu21
c84791e 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Jul 17, 2017
@popcornmix
Add device tree config for htu21
63c84d5 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Jul 21, 2017
@popcornmix
Add device tree config for htu21
a64e607 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Jul 21, 2017
@popcornmix
Add device tree config for htu21
c594627 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Jul 27, 2017
@popcornmix
Add device tree config for htu21
ac12079 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Jul 29, 2017
@popcornmix
Add device tree config for htu21
bb2c8dc 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Aug 1, 2017
@popcornmix
Add device tree config for htu21
1674f86 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Aug 8, 2017
@popcornmix
Add device tree config for htu21
99517f1 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Aug 8, 2017
@popcornmix
Add device tree config for htu21
b08c2b8 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Aug 10, 2017
@popcornmix
Add device tree config for htu21
2270a02 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Aug 13, 2017
@popcornmix
Add device tree config for htu21
80671bf 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Aug 13, 2017
@popcornmix
Add device tree config for htu21
a5aaf54 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Aug 14, 2017
@popcornmix
Add device tree config for htu21
257fea0 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Aug 23, 2017
@popcornmix
Add device tree config for htu21
68d6b75 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Aug 23, 2017
@popcornmix
Add device tree config for htu21
4d09f1c 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Aug 25, 2017
@popcornmix
Add device tree config for htu21
7ff5272 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Aug 30, 2017
@popcornmix
Add device tree config for htu21
e8033e0 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Sep 1, 2017
@popcornmix
Add device tree config for htu21
b0b8bbe 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Sep 4, 2017
@popcornmix
Add device tree config for htu21
345e65f 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Sep 8, 2017
@popcornmix
Add device tree config for htu21
afd46ed 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Sep 13, 2017
@popcornmix
Add device tree config for htu21
3a9958d 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Sep 13, 2017
@popcornmix
Add device tree config for htu21
1efd616 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Sep 14, 2017
@popcornmix
Add device tree config for htu21
990884a 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Sep 14, 2017
@popcornmix
Add device tree config for htu21
e332d7c 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Sep 22, 2017
@popcornmix
Add device tree config for htu21
02dd5e9 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit that referenced this pull request Oct 29, 2017
@popcornmix
Add device tree config for htu21
0ee1934 
See: #2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
raspbian-autopush pushed a commit to raspbian-packages/linux-4.9 that referenced this pull request Nov 2, 2017
@raspbian-autopush
rpi_1277_e06a6e0a41e70e56887f680e1920327b16839b87
5721157 
commit e06a6e0
Author: Stefan Tatschner <rumpelsepp@sevenbyte.org>
Date:   Mon May 29 21:46:16 2017 +0200

    Add device tree config for htu21
    
    See: raspberrypi/linux#2041
    
    Signed-off-by: Phil Elwell <phil@raspberrypi.org>


Gbp-Pq: Topic rpi
Gbp-Pq: Name rpi_1277_e06a6e0a41e70e56887f680e1920327b16839b87.patch
ryncsn pushed a commit to ryncsn/linux-rasp that referenced this pull request Nov 21, 2017
@ryncsn
Add device tree config for htu21
fb97fa6 
See: raspberrypi#2041

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
raspbian-autopush pushed a commit to raspbian-packages/linux-4.9 that referenced this pull request Apr 7, 2018
rpi_1279_1fb3e942d0d10ddc3d872cbee380655826a5961c
dde69a6 
commit 1fb3e94
Author: Stefan Tatschner <rumpelsepp@sevenbyte.org>
Date:   Mon May 29 21:46:16 2017 +0200

    Add device tree config for htu21
    
    See: raspberrypi/linux#2041
    
    Signed-off-by: Phil Elwell <phil@raspberrypi.org>


Gbp-Pq: Topic rpi
Gbp-Pq: Name rpi_1279_1fb3e942d0d10ddc3d872cbee380655826a5961c.patch
raspbian-autopush pushed a commit to raspbian-packages/linux-4.9 that referenced this pull request Nov 11, 2018
@raspbian-autopush
rpi_1279_1fb3e942d0d10ddc3d872cbee380655826a5961c
d8a0d2a 
commit 1fb3e94
Author: Stefan Tatschner <rumpelsepp@sevenbyte.org>
Date:   Mon May 29 21:46:16 2017 +0200

    Add device tree config for htu21
    
    See: raspberrypi/linux#2041
    
    Signed-off-by: Phil Elwell <phil@raspberrypi.org>


Gbp-Pq: Topic rpi
Gbp-Pq: Name rpi_1279_1fb3e942d0d10ddc3d872cbee380655826a5961c.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rumpelsepp @pelwell