Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vcsm for multiplatform #2206

Merged
merged 3 commits into from
Sep 26, 2017
Merged

Conversation

invisiblek
Copy link
Contributor

No description provided.

@invisiblek
Copy link
Contributor Author

the commit i pushed yesterday didn't actually address the multi platform problem, it simply fixed a compiler error

@popcornmix
Copy link
Collaborator

This seems to stop bcm2709_defconfig from building:

arch/arm/mm/built-in.o:(___ksymtab+dmac_clean_range+0x0): undefined reference to `dmac_clean_range'
arch/arm/mm/built-in.o:(___ksymtab+dmac_inv_range+0x0): undefined reference to `dmac_inv_range'
drivers/built-in.o: In function `.LANCHOR1':
arm_pmu.c:(.rodata+0x93c4): undefined reference to `dmac_inv_range'
arm_pmu.c:(.rodata+0x93cc): undefined reference to `dmac_clean_range'
Makefile:972: recipe for target 'vmlinux' failed

@invisiblek
Copy link
Contributor Author

Oh, I think I see what's up. I'll have something up shortly. I was only building multi-platform and overlooked non.

@invisiblek
Copy link
Contributor Author

Ok, should be good now. Squashed that fix in to the first commit (as it really does belong there). The diff: https://gist.github.com/invisiblek/31df3a271854f38b04021b51f33e9d64

@popcornmix
Copy link
Collaborator

This looks okay to me and builds with bcm2709_defconfig and bcmrpi_defconfig.
@pelwell okay with you?

@pelwell
Copy link
Contributor

pelwell commented Sep 26, 2017

Considering that we're changing upstream code it's as clean as it can be. I can live with this.

@popcornmix popcornmix merged commit 7b44f96 into raspberrypi:rpi-4.9.y Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants